chore: align-version script drops caret from dependencies it rewrites #27376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `align-version` script is supposed to rewrite `0.0.0` -> `2.99.0`, and also to rewrite `^0.0.0` -> `^2.99.0`. It didn't do the latter, because of a variable shadowing mistake. That mistake happened to come out correctly often enough that we didn't notice it. Fix that bug. Also add a linting rule that says that all peerDependencies should have a `^` dependency on `aws-cdk-lib`.
kaizencc
approved these changes
Oct 2, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2023
Synthetics was stabilized in #27305 and the alpha module was removed. Due to a bug in `align-versions.sh`, the last published `@aws-cdk/aws-synthetics-alpha` module relied on a peer dependency of `aws-cdk-lib@2.99.0` instead of `aws-cdk-lib@^2.99.0` (with the caret). This makes `@aws-cdk/aws-synthetics-alpha incompatible with later versions of aws-cdk-lib, and is unintentional. #27376 fixes the bug in `align-versions.sh`, and this PR re-introduces `@aws-cdk/aws-synthetics-alpha` for one last version of CDK (v2.100.0) before we remove it again. This should have the effect of `@aws-cdk/aws-synthetics-alpha@2.100.0` being the last version of the alpha module, but still compatible with later versions of `aws-cdk-lib` by having the peer dependency `aws-cdk-lib@^2.100.0`. We still want users to migrate to the stable synthetics module at `aws-cdk-lib/aws-synthetics`, but we don't want to outright break existing users of the experimental module either. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
align-versionscript is supposed to rewrite0.0.0->2.99.0, and also to rewrite^0.0.0->^2.99.0. It didn't do the latter, because of a variable shadowing mistake. That mistake happened to come out correctly often enough that we didn't notice it.Fix that bug.
Also add a linting rule that says that all peerDependencies should have a
^dependency onaws-cdk-lib.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license