Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(autoscaling): correct feature flag for launch templates #27235

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

iRoachie
Copy link
Contributor

The docs for AutoScalingGroup mention using the feature flag @aws-cdk/aws-autoscaling:disableDefaultLaunchConfigCreation in order to generate launch templates instead of launch configs.

This flag doesn't exist and the correct flag should be @aws-cdk/aws-autoscaling:generateLaunchTemplateInsteadOfLaunchConfig as specified on the feature flags page

Was raised by Carl Fürstenberg on the #aws-cdk slack channel


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Sep 21, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team September 21, 2023 13:14
@github-actions github-actions bot added the p2 label Sep 21, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c2b17da
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2a9f5b5 into aws:main Sep 21, 2023
@iRoachie iRoachie deleted the aws-autoscaling-docs branch September 21, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admired-contributor [Pilot] contributed between 13-24 PRs to the CDK p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants