fix(apigateway): CORS response body has unexpected space #27219
Conversation
Because of the way Velocity templates are parsed, the space just before `#end` in the original template was emitted literally instead of swallowed. This caused the `OPTIONS` response to contain a single space (`" "`), which makes some validation tools reject the response as invalid. Rewrite the Velocity template to a syntax we know doesn't cause that space to be emitted.
rix0rrr
changed the title
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
rix0rrr
added
the
pr-linter/exempt-integ-test
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Because of the way Velocity templates are parsed, the space just before
#endin the original template was emitted literally instead of swallowed.This caused the
OPTIONSresponse to contain a single space (" "), which makes some validation tools reject the response as invalid.Rewrite the Velocity template to a syntax we know doesn't cause that space to be emitted.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license