fix(cli): equals sign in a tag value is dropped #27130
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
aws-cdk-automation
added
the
pr/needs-cli-test-run
snaksa
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
|
Exemption Request: I could not find any existing integration tests. Please let me know in case I missed something. |
aws-cdk-automation
added
pr-linter/exemption-requested
snaksa
had a problem deploying
to
test-pipeline
GitHub Actions
Failure
mrgrain
added
pr-linter/exempt-integ-test
aws-cdk-automation
removed
the
pr/needs-maintainer-review
mrgrain
temporarily deployed
to
test-pipeline
GitHub Actions
Inactive
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
mrgrain
added
pr-linter/cli-integ-tested
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
When overriding tags from the CLI the tag key-value string is split by an equal sign and the left and right parts are used for key and value respectively. The documentation for the [String.prototype.split()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/split) states that the second parameter sets a limit of the returned values after execution: > If provided, splits the string at each occurrence of the specified separator, but stops when limit entries have been placed in the array. Any leftover text is not included in the array at all. So basically if we have `foo=bar=test` and we apply a split with a limit of 2 (`"foo=bar=test".split("=", 2)`) we will get the following array `["foo", "bar"]` instead of the expected one`["foo", "bar=test"]`. There has been the same problem with the context values and since it is the same problem the solution is also the same: #5773 With this fix the `context` and `tags` get the same behaviour when parsing the passed values. Closes #21003 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When overriding tags from the CLI the tag key-value string is split by an equal sign and the left and right parts are used for key and value respectively. The documentation for the String.prototype.split() states that the second parameter sets a limit of the returned values after execution:
So basically if we have
foo=bar=testand we apply a split with a limit of 2 ("foo=bar=test".split("=", 2)) we will get the following array["foo", "bar"]instead of the expected one["foo", "bar=test"].There has been the same problem with the context values and since it is the same problem the solution is also the same: #5773
With this fix the
contextandtagsget the same behaviour when parsing the passed values.Closes #21003
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license