Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(stepfunctions-tasks): algorithmName validation for SageMakerCreateTrainingJob #26877

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

tmyoda
Copy link
Contributor

@tmyoda tmyoda commented Aug 24, 2023

Referencing PR #26675, I have added validation for the algorithmName parameter in SageMakerCreateTrainingJob.
However, it was suggested that changes for validation should be separated. So, I have created this PR.

Docs for algorithmName:
https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AlgorithmSpecification.html#API_AlgorithmSpecification_Contents

Exemption Request:
This change does not alter the behavior.
I believe the unit test create-training-job.test.ts that I have added is sufficient to test this change.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Aug 24, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 24, 2023 21:56
@github-actions github-actions bot added the repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK label Aug 24, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@tmyoda
Copy link
Contributor Author

tmyoda commented Aug 24, 2023

Exemption Request:
This change does not alter the behavior.
I believe the unit test create-training-job.test.ts that I have added is sufficient to test this change.

@aws-cdk-automation aws-cdk-automation added pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Aug 24, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there!

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 25, 2023
@kaizencc kaizencc added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Aug 25, 2023
@kaizencc kaizencc changed the title fix(stepfunctions-tasks): Add algorithmName Validation for SageMakerCreateTrainingJob feat(stepfunctions-tasks): algorithmName validation for SageMakerCreateTrainingJob Aug 25, 2023
@kaizencc kaizencc added the pr-linter/exempt-readme The PR linter will not require README changes label Aug 25, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review August 25, 2023 17:48

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify mergify bot dismissed rix0rrr’s stale review August 28, 2023 21:18

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 28, 2023
@tmyoda tmyoda requested a review from rix0rrr August 28, 2023 22:59
rix0rrr
rix0rrr previously approved these changes Aug 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed rix0rrr’s stale review August 29, 2023 10:18

Pull request has been modified.

@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Aug 29, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fe68e1d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1cead3b into aws:main Aug 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants