-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stepfunctions-tasks): algorithmName
validation for SageMakerCreateTrainingJob
#26877
feat(stepfunctions-tasks): algorithmName
validation for SageMakerCreateTrainingJob
#26877
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there!
packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/sagemaker/create-training-job.ts
Outdated
Show resolved
Hide resolved
algorithmName
Validation for SageMakerCreateTrainingJob
algorithmName
validation for SageMakerCreateTrainingJob
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Referencing PR #26675, I have added validation for the
algorithmName
parameter inSageMakerCreateTrainingJob
.However, it was suggested that changes for validation should be separated. So, I have created this PR.
Docs for
algorithmName
:https://docs.aws.amazon.com/sagemaker/latest/APIReference/API_AlgorithmSpecification.html#API_AlgorithmSpecification_Contents
Exemption Request:
This change does not alter the behavior.
I believe the unit test
create-training-job.test.ts
that I have added is sufficient to test this change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license