Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update AWS Service Spec #26825

Merged
merged 5 commits into from
Aug 22, 2023
Merged

feat: update AWS Service Spec #26825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1061519
feat: update AWS Service Spec
aws-cdk-automation Aug 21, 2023
5c8420a
Merge branch 'main' into automation/spec-update
rix0rrr Aug 22, 2023
9485ff4
Adding missing `@stability external`
rix0rrr Aug 22, 2023
ef3385a
Allow this once
rix0rrr Aug 22, 2023
f0f2cae
Merge branch 'main' into automation/spec-update
mergify[bot] Aug 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions allowed-breaking-changes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,3 +173,14 @@ removed:aws-cdk-lib.aws_ecs.CfnTaskSet.LoadBalancerProperty.loadBalancerName
# Introduction of a new feature
# Previously only BlueGreenUpdatePolicy could be set, now BlueGreenUpdatePolicy or new RollingUpdatePolicy can be provided
weakened:aws-cdk-lib.aws_sagemaker.CfnEndpoint.DeploymentConfigProperty

# These should have been marked external
weakened:aws-cdk-lib.aws_events.CfnRule.RedshiftDataParametersProperty
weakened:aws-cdk-lib.aws_ivs.CfnRecordingConfiguration.DestinationConfigurationProperty
weakened:aws-cdk-lib.aws_ivs.CfnRecordingConfiguration.ThumbnailConfigurationProperty
removed:aws-cdk-lib.aws_sam.CfnFunction.AlexaSkillEventProperty.variables
strengthened:aws-cdk-lib.aws_sam.CfnFunction.AlexaSkillEventProperty
removed:aws-cdk-lib.aws_cloudwatch.CfnAlarm.attrId
removed:aws-cdk-lib.aws_ec2.CfnNetworkInterface.enablePrimaryIpv6
removed:aws-cdk-lib.aws_ec2.CfnNetworkInterfaceAttachment.attrId
removed:aws-cdk-lib.aws_ec2.CfnNetworkInterfaceProps.enablePrimaryIpv6
3 changes: 2 additions & 1 deletion tools/@aws-cdk/spec2cdk/lib/cdk/typedefinition-struct.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Resource, TypeDefinition } from '@aws-cdk/service-spec-types';
import { ClassType, Module, StructType } from '@cdklabs/typewriter';
import { ClassType, Module, Stability, StructType } from '@cdklabs/typewriter';
import { CloudFormationMapping } from './cloudformation-mapping';
import { TypeConverter } from './type-converter';
import { TypeDefinitionDecider } from './typedefinition-decider';
Expand Down Expand Up @@ -30,6 +30,7 @@ export class TypeDefinitionStruct extends StructType {
name: structNameFromTypeDefinition(options.typeDefinition),
docs: {
...splitDocumentation(options.typeDefinition.documentation),
stability: Stability.External,
see: cloudFormationDocLink({
resourceType: options.resource.cloudFormationType,
propTypeName: options.typeDefinition.name,
Expand Down
4 changes: 2 additions & 2 deletions tools/@aws-cdk/spec2cdk/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
},
"license": "Apache-2.0",
"dependencies": {
"@aws-cdk/aws-service-spec": "^0.0.7",
"@aws-cdk/service-spec-types": "^0.0.7",
"@aws-cdk/aws-service-spec": "^0.0.9",
"@aws-cdk/service-spec-types": "^0.0.9",
"@cdklabs/tskb": "^0.0.1",
"@cdklabs/typewriter": "^0.0.1",
"camelcase": "^6",
Expand Down
18 changes: 9 additions & 9 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,23 +55,23 @@
resolved "https://registry.npmjs.org/@aws-cdk/asset-node-proxy-agent-v6/-/asset-node-proxy-agent-v6-2.0.1.tgz#6dc9b7cdb22ff622a7176141197962360c33e9ac"
integrity sha512-DDt4SLdLOwWCjGtltH4VCST7hpOI5DzieuhGZsBpZ+AgJdSI2GCjklCXm0GCTwJG/SolkL5dtQXyUKgg9luBDg==

"@aws-cdk/aws-service-spec@^0.0.7":
version "0.0.7"
resolved "https://registry.npmjs.org/@aws-cdk/aws-service-spec/-/aws-service-spec-0.0.7.tgz#cc80f495653217bc40ce77192cb77b239c7c113f"
integrity sha512-qSaZZFFAq8RKvNT7eCd0kZhoyq4ShY3+yK2EK40QrJXJoWqb7P4eAyNDE/cD5ssvq+sIpHgAyMOgoUr1yr0L2w==
"@aws-cdk/aws-service-spec@^0.0.9":
version "0.0.9"
resolved "https://registry.npmjs.org/@aws-cdk/aws-service-spec/-/aws-service-spec-0.0.9.tgz#682b68c87d1205c10e30bf9501aa17e2d0af6d6e"
integrity sha512-Ig57mObnMf1szNm3u5GV3lhmgpi4EOtpvA0lKR33n+eF6zLDkTJmkb1dEtHSCYmDMBwwtmkWMePihkjFhFkOuQ==
dependencies:
"@aws-cdk/service-spec-types" "^0.0.7"
"@aws-cdk/service-spec-types" "^0.0.9"
"@cdklabs/tskb" "^0.0.1"

"@aws-cdk/lambda-layer-kubectl-v24@^2.0.242":
version "2.0.242"
resolved "https://registry.npmjs.org/@aws-cdk/lambda-layer-kubectl-v24/-/lambda-layer-kubectl-v24-2.0.242.tgz#4273a5ad7714f933a7eba155eb9280823086db71"
integrity sha512-7/wIOo685tmrEe4hh6zqDELhBZh5OQGf3Hd2FU2Vnwy2ZubW8qTmEw5gqJCsCrGKeYDoa1BcVhDRZ/nzjkaqyA==

"@aws-cdk/service-spec-types@^0.0.7":
version "0.0.7"
resolved "https://registry.npmjs.org/@aws-cdk/service-spec-types/-/service-spec-types-0.0.7.tgz#048d7b5aec312ee9aaa947a2b841cd69d982f797"
integrity sha512-3JGeTLToV+HmRCT1QPAmXaiH2QLz8E0LvpiHPWPwO1jCz9Q5jYgtwZTMP/jrp8es1G3fFcNGu2dEDdAbzC9gZA==
"@aws-cdk/service-spec-types@^0.0.9":
version "0.0.9"
resolved "https://registry.npmjs.org/@aws-cdk/service-spec-types/-/service-spec-types-0.0.9.tgz#0599747a2adfbe81ec028be30e0e2a2f477100a2"
integrity sha512-QOjAn3PVAcVkdzXO8QKwAn+kV2bO5Lbtq2pRRdQERVDJyX2OMI+ZmT6JP+dQKFHxPWEoYeSCjZl+KCa3JqOHjw==
dependencies:
"@cdklabs/tskb" "^0.0.1"

Expand Down