-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudwatch): add verticalAnnotations property to GraphWidget #26819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
7d3a43d
to
372fa84
Compare
Is this failed test related to the introduced changes? Can someone help me out here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One small nits about the date time specification
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Adds a verticalAnnotation property to GraphWidget, reference: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Annotation-Format Shoutout to brendo-m for coming up with the solution Closes aws#7622.
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…6819) Adds a verticalAnnotation property to GraphWidget, reference: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Annotation-Format Shoutout to brendo-m for coming up with the solution Closes #7622. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR added support for start and end time of the schedule. ## Description Currently, users cannot set a start time and an end time for the schedule. A schedule without a start date will begin as soon as it is created and available, and without an end date, it will continue to invoke its target indefinitely. With this feature, users can set the start and end dates of a schedule, allowing for more flexible schedule configurations. https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedule.html#cfn-scheduler-schedule-startdate https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-scheduler-schedule.html#cfn-scheduler-schedule-enddate In CloudFormation, users can use this feature as follows: ```yaml TestSchedule: Type: AWS::Scheduler::Schedule Properties: StartDate: "2024-12-01T13:09:00.000Z" EndDate: "2025-12-01T00:00:00.001Z" ScheduleExpression: "at(2023-01-01T00:00:00)" State: "ENABLED" Target: # target ``` ## Major changes ### add property to ScheduleProps interface Added startDate and endDate properties, and typed these values as string based on the following PR comments. #26819 (comment) It is not necessary to specify both startDate and endDate, they can be set independently. Validation is performed on the following points. - Error if not following ISO 8601 format. - Must include milliseconds (yyyy-MM-ddTHH:mm:ss.SSSZ) - Error if startDate is later than endDate If a time before the current time is specified, the following error occurs in CFn, but no validation is performed because the timing of validation in CDK and the timing of actual deployment are different. `The StartDate you specify cannot be earlier than 5 minutes ago.` ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | | | lockFileMaintenance | All locks refreshed | [![age](https://developer.mend.io/api/mc/badges/age///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption///?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility////?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence////?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-alpha](https://togithub.com/aws/aws-cdk) ([source](https://togithub.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/aws-apigatewayv2-alpha)) | dependencies | minor | [`2.113.0-alpha.0` -> `2.114.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.113.0-alpha.0/2.114.1-alpha.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.113.0-alpha.0/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-cdk%2faws-apigatewayv2-alpha/2.113.0-alpha.0/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-cdk/aws-apigatewayv2-integrations-alpha](https://togithub.com/aws/aws-cdk) ([source](https://togithub.com/aws/aws-cdk/tree/HEAD/packages/@aws-cdk/aws-apigatewayv2-integrations-alpha)) | dependencies | minor | [`2.113.0-alpha.0` -> `2.114.1-alpha.0`](https://renovatebot.com/diffs/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.113.0-alpha.0/2.114.1-alpha.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.113.0-alpha.0/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-cdk%2faws-apigatewayv2-integrations-alpha/2.113.0-alpha.0/2.114.1-alpha.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@aws-sdk/client-secrets-manager](https://togithub.com/aws/aws-sdk-js-v3/tree/main/clients/client-secrets-manager) ([source](https://togithub.com/aws/aws-sdk-js-v3/tree/HEAD/clients/client-secrets-manager)) | dependencies | minor | [`3.465.0` -> `3.478.0`](https://renovatebot.com/diffs/npm/@aws-sdk%2fclient-secrets-manager/3.465.0/3.478.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@aws-sdk%2fclient-secrets-manager/3.478.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@aws-sdk%2fclient-secrets-manager/3.478.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@aws-sdk%2fclient-secrets-manager/3.465.0/3.478.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@aws-sdk%2fclient-secrets-manager/3.465.0/3.478.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@trautonen/cdk-dns-validated-certificate](https://togithub.com/trautonen/cdk-dns-validated-certificate) | dependencies | patch | [`0.0.32` -> `0.0.35`](https://renovatebot.com/diffs/npm/@trautonen%2fcdk-dns-validated-certificate/0.0.32/0.0.35) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@trautonen%2fcdk-dns-validated-certificate/0.0.35?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@trautonen%2fcdk-dns-validated-certificate/0.0.35?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@trautonen%2fcdk-dns-validated-certificate/0.0.32/0.0.35?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@trautonen%2fcdk-dns-validated-certificate/0.0.32/0.0.35?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/jest](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/jest) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest)) | devDependencies | patch | [`29.5.10` -> `29.5.11`](https://renovatebot.com/diffs/npm/@types%2fjest/29.5.10/29.5.11) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fjest/29.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fjest/29.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fjest/29.5.10/29.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fjest/29.5.10/29.5.11?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/luxon](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/luxon) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/luxon)) | devDependencies | patch | [`3.3.6` -> `3.3.7`](https://renovatebot.com/diffs/npm/@types%2fluxon/3.3.6/3.3.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fluxon/3.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fluxon/3.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fluxon/3.3.6/3.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fluxon/3.3.6/3.3.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [@types/node](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/node) ([source](https://togithub.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node)) | devDependencies | patch | [`20.10.2` -> `20.10.5`](https://renovatebot.com/diffs/npm/@types%2fnode/20.10.2/20.10.5) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@types%2fnode/20.10.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@types%2fnode/20.10.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@types%2fnode/20.10.2/20.10.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@types%2fnode/20.10.2/20.10.5?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk](https://togithub.com/aws/aws-cdk) ([source](https://togithub.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk)) | devDependencies | minor | [`2.113.0` -> `2.115.0`](https://renovatebot.com/diffs/npm/aws-cdk/2.113.0/2.115.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/aws-cdk/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/aws-cdk/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/aws-cdk/2.113.0/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/aws-cdk/2.113.0/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [aws-cdk-lib](https://togithub.com/aws/aws-cdk) ([source](https://togithub.com/aws/aws-cdk/tree/HEAD/packages/aws-cdk-lib)) | dependencies | minor | [`2.113.0` -> `2.115.0`](https://renovatebot.com/diffs/npm/aws-cdk-lib/2.113.0/2.115.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/aws-cdk-lib/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/aws-cdk-lib/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/aws-cdk-lib/2.113.0/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/aws-cdk-lib/2.113.0/2.115.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [esbuild](https://togithub.com/evanw/esbuild) | devDependencies | patch | [`0.19.8` -> `0.19.10`](https://renovatebot.com/diffs/npm/esbuild/0.19.8/0.19.10) | [![age](https://developer.mend.io/api/mc/badges/age/npm/esbuild/0.19.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/esbuild/0.19.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/esbuild/0.19.8/0.19.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/esbuild/0.19.8/0.19.10?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [ts-node](https://typestrong.org/ts-node) ([source](https://togithub.com/TypeStrong/ts-node)) | devDependencies | patch | [`10.9.1` -> `10.9.2`](https://renovatebot.com/diffs/npm/ts-node/10.9.1/10.9.2) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ts-node/10.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-node/10.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-node/10.9.1/10.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-node/10.9.1/10.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [typescript](https://www.typescriptlang.org/) ([source](https://togithub.com/Microsoft/TypeScript)) | devDependencies | patch | [`5.3.2` -> `5.3.3`](https://renovatebot.com/diffs/npm/typescript/5.3.2/5.3.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/typescript/5.3.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/typescript/5.3.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/typescript/5.3.2/5.3.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/typescript/5.3.2/5.3.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | 🔧 This Pull Request updates lock files to use the latest dependency versions. --- ### Release Notes <details> <summary>aws/aws-sdk-js-v3 (@​aws-sdk/client-secrets-manager)</summary> ### [`v3.478.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34780-2023-12-20) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.477.0...v3.478.0) ##### Features - codegen for paginator factory ([#​5590](https://togithub.com/aws/aws-sdk-js-v3/issues/5590)) ([e54099b](https://togithub.com/aws/aws-sdk-js-v3/commit/e54099b7c1eb3b1de5737d5494821b1dae045fca)) ### [`v3.477.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34770-2023-12-19) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.476.0...v3.477.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) ### [`v3.476.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34760-2023-12-18) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.474.0...v3.476.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) ### [`v3.474.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34740-2023-12-14) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.473.0...v3.474.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) ### [`v3.473.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34730-2023-12-13) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.470.0...v3.473.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) ### [`v3.470.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34700-2023-12-08) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.468.0...v3.470.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) ### [`v3.468.0`](https://togithub.com/aws/aws-sdk-js-v3/blob/HEAD/clients/client-secrets-manager/CHANGELOG.md#34680-2023-12-06) [Compare Source](https://togithub.com/aws/aws-sdk-js-v3/compare/v3.465.0...v3.468.0) **Note:** Version bump only for package [@​aws-sdk/client-secrets-manager](https://togithub.com/aws-sdk/client-secrets-manager) </details> <details> <summary>trautonen/cdk-dns-validated-certificate (@​trautonen/cdk-dns-validated-certificate)</summary> ### [`v0.0.35`](https://togithub.com/trautonen/cdk-dns-validated-certificate/releases/tag/v0.0.35) [Compare Source](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.34...v0.0.35) ##### [0.0.35](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.34...v0.0.35) (2023-12-18) ### [`v0.0.34`](https://togithub.com/trautonen/cdk-dns-validated-certificate/releases/tag/v0.0.34) [Compare Source](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.33...v0.0.34) ##### [0.0.34](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.33...v0.0.34) (2023-12-11) ### [`v0.0.33`](https://togithub.com/trautonen/cdk-dns-validated-certificate/releases/tag/v0.0.33) [Compare Source](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.32...v0.0.33) ##### [0.0.33](https://togithub.com/trautonen/cdk-dns-validated-certificate/compare/v0.0.32...v0.0.33) (2023-12-04) </details> <details> <summary>aws/aws-cdk (aws-cdk)</summary> ### [`v2.115.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.115.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.114.1...v2.115.0) ##### Features - **eks:** support Bottlerocket Nvidia AMIs ([#​28287](https://togithub.com/aws/aws-cdk/issues/28287)) ([6aa1b1b](https://togithub.com/aws/aws-cdk/commit/6aa1b1b02ab3782b0e6419f8d5a340663cb47c81)), closes [#​28241](https://togithub.com/aws/aws-cdk/issues/28241) - **rds:** support RDS for MariaDB 10.11.6, 10.6.16, 10.5.23 and 10.4.32 ([#​28345](https://togithub.com/aws/aws-cdk/issues/28345)) ([0347a19](https://togithub.com/aws/aws-cdk/commit/0347a19e49533971e4e57b7e04271dffc541ff92)) - **rds:** support RDS for SQL Server 16.00.4095.4.v1 ([#​28274](https://togithub.com/aws/aws-cdk/issues/28274)) ([7a22501](https://togithub.com/aws/aws-cdk/commit/7a22501d58912f777ae0a2ad1b48af2faeb6946b)) - **stepfunctions-tasks:** runtime role in EmrAddStep ([#​27736](https://togithub.com/aws/aws-cdk/issues/27736)) ([314fbfa](https://togithub.com/aws/aws-cdk/commit/314fbfa34cf1207417ad590d6bb6a8742664a380)), closes [#​27691](https://togithub.com/aws/aws-cdk/issues/27691) - **stepfunctions-tasks:** support for the Step Functions optimized integration for Bedrock InvokeModel API ([#​28276](https://togithub.com/aws/aws-cdk/issues/28276)) ([f3dafa4](https://togithub.com/aws/aws-cdk/commit/f3dafa49ec900fc044384441a9163d7ed6a63dda)) - update AWS Service Spec ([#​28328](https://togithub.com/aws/aws-cdk/issues/28328)) ([15c7bb2](https://togithub.com/aws/aws-cdk/commit/15c7bb2908cff1ab8bebacacc09f26bbab6ec391)) - **ROADMAP:** updates to public roadmap 🚀 ([#​28302](https://togithub.com/aws/aws-cdk/issues/28302)) ([fe30921](https://togithub.com/aws/aws-cdk/commit/fe30921c358e535bf734c768fdfb64aca1c4c4ab)) ##### Bug Fixes - **rds:** publiclyAccessible=false set on an instance is ignored when cluster is placed in a public subnet ([#​28038](https://togithub.com/aws/aws-cdk/issues/28038)) ([569593c](https://togithub.com/aws/aws-cdk/commit/569593c78467404825beb277d75436bd32cdf0f9)), closes [#​28037](https://togithub.com/aws/aws-cdk/issues/28037) [#​28037](https://togithub.com/aws/aws-cdk/issues/28037) - **route53:** delete old NS records on cross-account delegation renaming ([#​21249](https://togithub.com/aws/aws-cdk/issues/21249)) ([#​27523](https://togithub.com/aws/aws-cdk/issues/27523)) ([448e2bd](https://togithub.com/aws/aws-cdk/commit/448e2bda5632621c057c2e448cd34cfec107b22e)), closes [#​25285](https://togithub.com/aws/aws-cdk/issues/25285) - **stepfunctions-tasks:** missing tags & perms for emr cluster creation ([#​28327](https://togithub.com/aws/aws-cdk/issues/28327)) ([14e5e50](https://togithub.com/aws/aws-cdk/commit/14e5e50e9e4a23ab7db5bbccf874e6a5fe731e34)) - **stepfunctions-tasks:** state machine role is missing sagemaker:AddTags permission for SageMakerCreateTransformJob task ([#​27264](https://togithub.com/aws/aws-cdk/issues/27264)) ([8ce0283](https://togithub.com/aws/aws-cdk/commit/8ce02838ba5033a6b35123a34e444c4f35350975)), closes [#​26012](https://togithub.com/aws/aws-cdk/issues/26012) *** ##### Alpha modules (2.115.0-alpha.0) ##### ⚠ BREAKING CHANGES TO EXPERIMENTAL FEATURES - **scheduler:** The typos in the Schedule and Group construct method names have been fixed, changing `metricSentToDLQTrunacted` to `metricSentToDLQTruncated` and `metricAllSentToDLQTrunacted` to `metricAllSentToDLQTruncated`. - **redshift:** Further updates of the Redshift table will fail for existing tables, if the table name is changed. Therefore, changing the table name for existing Redshift tables have been disabled. ##### Features - **appconfig-alpha:** add deploy method to configuration constructs ([#​28269](https://togithub.com/aws/aws-cdk/issues/28269)) ([c723ef9](https://togithub.com/aws/aws-cdk/commit/c723ef913a73fa6a452042db926023d174e86dbf)) - **cloud9-alpha:** support image ids for Amazon Linux 2023 and Ubuntu 22.04 ([#​28346](https://togithub.com/aws/aws-cdk/issues/28346)) ([93681e0](https://togithub.com/aws/aws-cdk/commit/93681e07ad19c08f60eb2ee5748a2d55c6d2bc45)), closes [/docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-cloud9-environmentec2.html#cfn-cloud9-environmentec2](https://togithub.com/aws//docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-cloud9-environmentec2.html/issues/cfn-cloud9-environmentec2) - **scheduler:** start and end time for schedule construct ([#​28306](https://togithub.com/aws/aws-cdk/issues/28306)) ([0b4ab1d](https://togithub.com/aws/aws-cdk/commit/0b4ab1d0ba11b3536a2f7b02b537966de6ac0493)), closes [/github.com/aws/aws-cdk/pull/26819#discussion_r1301532299](https://togithub.com/aws//github.com/aws/aws-cdk/pull/26819/issues/discussion_r1301532299) ##### Bug Fixes - **appconfig-alpha:** extensions always create cdk diff ([#​28264](https://togithub.com/aws/aws-cdk/issues/28264)) ([2075559](https://togithub.com/aws/aws-cdk/commit/207555919e0462686f6c434d1598e371687679c8)), closes [#​27676](https://togithub.com/aws/aws-cdk/issues/27676) - **redshift:** tables were dropped on table name change ([#​24308](https://togithub.com/aws/aws-cdk/issues/24308)) ([7ac237b](https://togithub.com/aws/aws-cdk/commit/7ac237b08c489883962d6b8023799d6c2c40cfba)), closes [#​24246](https://togithub.com/aws/aws-cdk/issues/24246) - **scheduler:** typo in metricSentToDLQ... methods ([#​28307](https://togithub.com/aws/aws-cdk/issues/28307)) ([8b91e10](https://togithub.com/aws/aws-cdk/commit/8b91e106e649e6a75b396f350dae9266770ad6cb)) ### [`v2.114.1`](https://togithub.com/aws/aws-cdk/releases/tag/v2.114.1) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.114.0...v2.114.1) ##### Bug Fixes - **route53:** delete old NS records on cross-account delegation renaming ([#​21249](https://togithub.com/aws/aws-cdk/issues/21249)) ([#​27523](https://togithub.com/aws/aws-cdk/issues/27523)) ([8c38a3a](https://togithub.com/aws/aws-cdk/commit/8c38a3a7f378d8b9917fd1279619a329efe4d02a)), closes [#​25285](https://togithub.com/aws/aws-cdk/issues/25285) *** ##### Alpha modules (2.114.1-alpha.0) ### [`v2.114.0`](https://togithub.com/aws/aws-cdk/releases/tag/v2.114.0) [Compare Source](https://togithub.com/aws/aws-cdk/compare/v2.113.0...v2.114.0) ##### Features - update AWS Service Spec ([#​28259](https://togithub.com/aws/aws-cdk/issues/28259)) ([a11ab23](https://togithub.com/aws/aws-cdk/commit/a11ab23f43a5d1664cc2f22cf4ee2e696002f09c)) - **rds:** grantConnect method enables iam auth to rds cluster ([#​28118](https://togithub.com/aws/aws-cdk/issues/28118)) ([766ff8b](https://togithub.com/aws/aws-cdk/commit/766ff8b3c5ac1b03da98fb6b2f70e96182401f89)) ##### Bug Fixes - **apigateway:** move url property to RestApiBase ([#​27742](https://togithub.com/aws/aws-cdk/issues/27742)) ([b23ee1b](https://togithub.com/aws/aws-cdk/commit/b23ee1be9381f0f927e43c4214e91aafcdf03899)), closes [#​27501](https://togithub.com/aws/aws-cdk/issues/27501) - **apigatewayv2:** export newly graduated apigatewayv2 modules ([#​28250](https://togithub.com/aws/aws-cdk/issues/28250)) ([c8627ce](https://togithub.com/aws/aws-cdk/commit/c8627cef3a4f4e05c2e3d088c0903dd1a9c9ef4f)), closes [#​28239](https://togithub.com/aws/aws-cdk/issues/28239) - **iam:** attaching a policy is not idempotent with imported resources ([#​28129](https://togithub.com/aws/aws-cdk/issues/28129)) ([0abd0b5](https://togithub.com/aws/aws-cdk/commit/0abd0b5552602322d224dca57ea119a01056b6f3)), closes [#​28101](https://togithub.com/aws/aws-cdk/issues/28101) - **stepfunctions-tasks:** mwaa service generates wrong action in role policy ([#​28082](https://togithub.com/aws/aws-cdk/issues/28082)) ([24cbb51](https://togithub.com/aws/aws-cdk/commit/24cbb519259e8f056bfc0fe138861478c0c7a6d3)), closes [#​27623](https://togithub.com/aws/aws-cdk/issues/27623) [#​28081](https://togithub.com/aws/aws-cdk/issues/28081) *** ##### Alpha modules (2.114.0-alpha.0) ##### Features - **appconfig-alpha:** support for composite alarms ([#​28156](https://togithub.com/aws/aws-cdk/issues/28156)) ([d19640b](https://togithub.com/aws/aws-cdk/commit/d19640b1130f3701945173a81d217763386378a8)) - **appconfig-alpha:** support for relative file paths when importing config ([#​28191](https://togithub.com/aws/aws-cdk/issues/28191)) ([4867294](https://togithub.com/aws/aws-cdk/commit/4867294467791b14347feef65fc3ad262bc5834a)), closes [#​26937](https://togithub.com/aws/aws-cdk/issues/26937) - **scheduler-targets-alpha:** `KinesisDataFirehosePutRecord` Target ([#​27842](https://togithub.com/aws/aws-cdk/issues/27842)) ([46f3a00](https://togithub.com/aws/aws-cdk/commit/46f3a00c5f030fa8c6a92fb76063fba45f9b467c)), closes [#​27450](https://togithub.com/aws/aws-cdk/issues/27450) - **scheduler-targets-alpha:** `KinesisStreamPutRecord` Target ([#​27845](https://togithub.com/aws/aws-cdk/issues/27845)) ([47a09b5](https://togithub.com/aws/aws-cdk/commit/47a09b590b5e14385f028e61ed42cd460d122fae)), closes [#​27451](https://togithub.com/aws/aws-cdk/issues/27451) </details> <details> <summary>evanw/esbuild (esbuild)</summary> ### [`v0.19.10`](https://togithub.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#01910) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.19.9...v0.19.10) - Fix glob imports in TypeScript files ([#​3319](https://togithub.com/evanw/esbuild/issues/3319)) This release fixes a problem where bundling a TypeScript file containing a glob import could emit a call to a helper function that doesn't exist. The problem happened because esbuild's TypeScript transformation removes unused imports (which is required for correctness, as they may be type-only imports) and esbuild's glob import transformation wasn't correctly marking the imported helper function as used. This wasn't caught earlier because most of esbuild's glob import tests were written in JavaScript, not in TypeScript. - Fix `require()` glob imports with bundling disabled ([#​3546](https://togithub.com/evanw/esbuild/issues/3546)) Previously `require()` calls containing glob imports were incorrectly transformed when bundling was disabled. All glob imports should only be transformed when bundling is enabled. This bug has been fixed. - Fix a panic when transforming optional chaining with `define` ([#​3551](https://togithub.com/evanw/esbuild/issues/3551), [#​3554](https://togithub.com/evanw/esbuild/pull/3554)) This release fixes a case where esbuild could crash with a panic, which was triggered by using `define` to replace an expression containing an optional chain. Here is an example: ```js // Original code console.log(process?.env.SHELL) // Old output (with --define:process.env={}) /* panic: Internal error (while parsing "<stdin>") */ // New output (with --define:process.env={}) var define_process_env_default = {}; console.log(define_process_env_default.SHELL); ``` This fix was contributed by [@​hi-ogawa](https://togithub.com/hi-ogawa). - Work around a bug in node's CommonJS export name detector ([#​3544](https://togithub.com/evanw/esbuild/issues/3544)) The export names of a CommonJS module are dynamically-determined at run time because CommonJS exports are properties on a mutable object. But the export names of an ES module are statically-determined at module instantiation time by using `import` and `export` syntax and cannot be changed at run time. When you import a CommonJS module into an ES module in node, node scans over the source code to attempt to detect the set of export names that the CommonJS module will end up using. That statically-determined set of names is used as the set of names that the ES module is allowed to import at module instantiation time. However, this scan appears to have bugs (or at least, can cause false positives) because it doesn't appear to do any scope analysis. Node will incorrectly consider the module to export something even if the assignment is done to a local variable instead of to the module-level `exports` object. For example: ```js // confuseNode.js exports.confuseNode = function(exports) { // If this local is called "exports", node incorrectly // thinks this file has an export called "notAnExport". exports.notAnExport = function() { }; }; ``` You can see that node incorrectly thinks the file `confuseNode.js` has an export called `notAnExport` when that file is loaded in an ES module context: ```console $ node -e 'import("./confuseNode.js").then(console.log)' [Module: null prototype] { confuseNode: [Function (anonymous)], default: { confuseNode: [Function (anonymous)] }, notAnExport: undefined } ``` To avoid this, esbuild will now rename local variables that use the names `exports` and `module` when generating CommonJS output for the `node` platform. - Fix the return value of esbuild's `super()` shim ([#​3538](https://togithub.com/evanw/esbuild/issues/3538)) Some people write `constructor` methods that use the return value of `super()` instead of using `this`. This isn't too common because [TypeScript doesn't let you do that](https://togithub.com/microsoft/TypeScript/issues/37847) but it can come up when writing JavaScript. Previously esbuild's class lowering transform incorrectly transformed the return value of `super()` into `undefined`. With this release, the return value of `super()` will now be `this` instead: ```js // Original code class Foo extends Object { field constructor() { console.log(typeof super()) } } new Foo // Old output (with --target=es6) class Foo extends Object { constructor() { var __super = (...args) => { super(...args); __publicField(this, "field"); }; console.log(typeof __super()); } } new Foo(); // New output (with --target=es6) class Foo extends Object { constructor() { var __super = (...args) => { super(...args); __publicField(this, "field"); return this; }; console.log(typeof __super()); } } new Foo(); ``` - Terminate the Go GC when esbuild's `stop()` API is called ([#​3552](https://togithub.com/evanw/esbuild/issues/3552)) If you use esbuild with WebAssembly and pass the `worker: false` flag to `esbuild.initialize()`, then esbuild will run the WebAssembly module on the main thread. If you do this within a Deno test and that test calls `esbuild.stop()` to clean up esbuild's resources, Deno may complain that a `setTimeout()` call lasted past the end of the test. This happens when the Go is in the middle of a garbage collection pass and has scheduled additional ongoing garbage collection work. Normally calling `esbuild.stop()` will terminate the web worker that the WebAssembly module runs in, which will terminate the Go GC, but that doesn't happen if you disable the web worker with `worker: false`. With this release, esbuild will now attempt to terminate the Go GC in this edge case by calling `clearTimeout()` on these pending timeouts. - Apply `/* @​__NO_SIDE_EFFECTS__ */` on tagged template literals ([#​3511](https://togithub.com/evanw/esbuild/issues/3511)) Tagged template literals that reference functions annotated with a `@__NO_SIDE_EFFECTS__` comment are now able to be removed via tree-shaking if the result is unused. This is a convention from [Rollup](https://togithub.com/rollup/rollup/pull/5024). Here is an example: ```js // Original code const html = /* @​__NO_SIDE_EFFECTS__ */ (a, ...b) => ({ a, b }) html`<a>remove</a>` x = html`<b>keep</b>` // Old output (with --tree-shaking=true) const html = /* @​__NO_SIDE_EFFECTS__ */ (a, ...b) => ({ a, b }); html`<a>remove</a>`; x = html`<b>keep</b>`; // New output (with --tree-shaking=true) const html = /* @​__NO_SIDE_EFFECTS__ */ (a, ...b) => ({ a, b }); x = html`<b>keep</b>`; ``` Note that this feature currently only works within a single file, so it's not especially useful. This feature does not yet work across separate files. I still recommend using `@__PURE__` annotations instead of this feature, as they have wider tooling support. The drawback of course is that `@__PURE__` annotations need to be added at each call site, not at the declaration, and for non-call expressions such as template literals you need to wrap the expression in an IIFE (immediately-invoked function expression) to create a call expression to apply the `@__PURE__` annotation to. - Publish builds for IBM AIX PowerPC 64-bit ([#​3549](https://togithub.com/evanw/esbuild/issues/3549)) This release publishes a binary executable to npm for IBM AIX PowerPC 64-bit, which means that in theory esbuild can now be installed in that environment with `npm install esbuild`. This hasn't actually been tested yet. If you have access to such a system, it would be helpful to confirm whether or not doing this actually works. ### [`v0.19.9`](https://togithub.com/evanw/esbuild/blob/HEAD/CHANGELOG.md#0199) [Compare Source](https://togithub.com/evanw/esbuild/compare/v0.19.8...v0.19.9) - Add support for transforming new CSS gradient syntax for older browsers The specification called [CSS Images Module Level 4](https://www.w3.org/TR/css-images-4/) introduces new CSS gradient syntax for customizing how the browser interpolates colors in between color stops. You can now control the color space that the interpolation happens in as well as (for "polar" color spaces) control whether hue angle interpolation happens clockwise or counterclockwise. You can read more about this in [Mozilla's blog post about new CSS gradient features](https://developer.mozilla.org/en-US/blog/css-color-module-level-4/). With this release, esbuild will now automatically transform this syntax for older browsers in the `target` list. For example, here's a gradient that should appear as a rainbow in a browser that supports this new syntax: ```css /* Original code */ .rainbow-gradient { width: 100px; height: 100px; background: linear-gradient(in hsl longer hue, #​7ff, #​77f); } /* New output (with --target=chrome99) */ .rainbow-gradient { width: 100px; height: 100px; background: linear-gradient( #​77ffff, #​77ffaa 12.5%, #​77ff80 18.75%, #​84ff77 21.88%, #​99ff77 25%, #eeff77 37.5%, #fffb77 40.62%, #ffe577 43.75%, #ffbb77 50%, #ff9077 56.25%, #ff7b77 59.38%, #ff7788 62.5%, #ff77dd 75%, #ff77f2 78.12%, #f777ff 81.25%, #cc77ff 87.5%, #​7777ff); } ``` You can now use this syntax in your CSS source code and esbuild will automatically convert it to an equivalent gradient for older browsers. In addition, esbuild will now also transform "double position" and "transition hint" syntax for older browsers as appropriate: ```css /* Original code */ .stripes { width: 100px; height: 100px; background: linear-gradient(#e65 33%, #ff2 33% 67%, #​99e 67%); } .glow { width: 100px; height: 100px; background: radial-gradient(white 10%, 20%, black); } /* New output (with --target=chrome33) */ .stripes { width: 100px; height: 100px; background: linear-gradient( #e65 33%, #ff2 33%, #ff2 67%, #​99e 67%); } .glow { width: 100px; height: 100px; background: radial-gradient( #ffffff 10%, #aaaaaa 12.81%, #​959595 15.62%, #​7b7b7b 21.25%, #​5a5a5a 32.5%, #​444444 43.75%, #​323232 55%, #​161616 77.5%, #​000000); } ``` You can see visual examples of these new syntax features by looking at [esbuild's gradient transformation tests](https://esbuild.github.io/gradient-tests/). If necessary, esbuild will construct a new gradient that approximates the original gradient by recursively splitting the interval in between color stops until the approximation error is within a small threshold. That is why the above output CSS contains many more color stops than the input CSS. Note that esbuild deliberately *replaces* the original gradient with the approximation instead of inserting the approximation before the original gradient as a fallback. The latest version of Firefox has multiple gradient rendering bugs (including incorrect interpolation of partially-transparent colors and interpolating non-sRGB colors using the incorrect color space). If esbuild didn't replace the original gradient, then Firefox would use the original gradient instead of the fallback the appearance would be incorrect in Firefox. In other words, the latest version of Firefox supports modern gradient syntax but interprets it incorrectly. - Add support for `color()`, `lab()`, `lch()`, `oklab()`, `oklch()`, and `hwb()` in CSS CSS has recently added lots of new ways of specifying colors. You can read more about this in [Chrome's blog post about CSS color spaces](https://developer.chrome.com/docs/css-ui/high-definition-css-color-guide). This release adds support for minifying colors that use the `color()`, `lab()`, `lch()`, `oklab()`, `oklch()`, or `hwb()` syntax and/or transforming these colors for browsers that don't support it yet: ```css /* Original code */ div { color: hwb(90deg 20% 40%); background: color(display-p3 1 0 0); } /* New output (with --target=chrome99) */ div { color: #​669933; background: #ff0f0e; background: color(display-p3 1 0 0); } ``` As you can see, colors outside of the sRGB color space such as `color(display-p3 1 0 0)` are mapped back into the sRGB gamut and inserted as a fallback for browsers that don't support the new color syntax. - Allow empty type parameter lists in certain cases ([#​3512](https://togithub.com/evanw/esbuild/issues/3512)) TypeScript allows interface declarations and type aliases to have empty type parameter lists. Previously esbuild didn't handle this edge case but with this release, esbuild will now parse this syntax: ```ts interface Foo<> {} type Bar<> = {} ``` This fix was contributed by [@​magic-akari](https://togithub.com/magic-akari). </details> <details> <summary>TypeStrong/ts-node (ts-node)</summary> ### [`v10.9.2`](https://togithub.com/TypeStrong/ts-node/releases/tag/v10.9.2): Fix `tsconfig.json` file not found [Compare Source](https://togithub.com/TypeStrong/ts-node/compare/v10.9.1...v10.9.2) **Fixed** - Fixed `tsconfig.json` file not found on latest TypeScript version ([https://github.com/TypeStrong/ts-node/pull/2091](https://togithub.com/TypeStrong/ts-node/pull/2091)) </details> <details> <summary>Microsoft/TypeScript (typescript)</summary> ### [`v5.3.3`](https://togithub.com/microsoft/TypeScript/releases/tag/v5.3.3): TypeScript 5.3.3 [Compare Source](https://togithub.com/Microsoft/TypeScript/compare/v5.3.2...v5.3.3) For release notes, check out the [release announcement](https://devblogs.microsoft.com/typescript/announcing-typescript-5-3/). For the complete list of fixed issues, check out the - [fixed issues query for Typescript 5.3.0 (Beta)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.0%22+is%3Aclosed+). - [fixed issues query for Typescript 5.3.1 (RC)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.1%22+is%3Aclosed+). - [fixed issues query for Typescript 5.3.2 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.2%22+is%3Aclosed+). - [fixed issues query for Typescript 5.3.3 (Stable)](https://togithub.com/Microsoft/TypeScript/issues?utf8=%E2%9C%93\&q=milestone%3A%22TypeScript+5.3.3%22+is%3Aclosed+). Downloads are available on: - [NuGet package](https://www.nuget.org/packages/Microsoft.TypeScript.MSBuild) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am on sunday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/aws-utils). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuMTAzLjEiLCJ0YXJnZXRCcmFuY2giOiJtYXN0ZXIifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Leveraging aws/aws-cdk#26819 --- _By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license_
Adds a verticalAnnotation property to GraphWidget, reference: https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html#CloudWatch-Dashboard-Properties-Annotation-Format
Shoutout to brendo-m for coming up with the solution
Closes #7622.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license