chore(prlint): account for same user with multiple reviews #26765
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the same user can have both a
COMMENTED
review and aAPPROVED
review. See #26763 and the logs from its prlinter github action:Also added more logging so that we can see the full data next time. This PR solves the issue by respecting
APPROVED
overCOMMENTED
. Any trusted reviewer who hasAPPROVED
a PR will get the PR topr/needs-maintainer-review
. Maintainers can always dismiss those reviews if we find that we want to respect someone else'sCOMMENTED
review.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license