-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove DEFAULT_CR_NODE_VERSION regional map #26665
Conversation
Removes the map of regions -> available lambda nodejs runtime versions that previously was used for all custom resources vended in the aws-cdk.
I guess we maybe don't need this map anymore, but wouldn't it be helpful to have a single place where we write down our default CR version? So that when Node 20 is released, we don't have to hunt and peck through our code to go and replace 18 -> 20 in 5820 different places, but can do it in one place? |
Helpful yes but I think the mechanism should be different to allow migrating resources one by one in case of runtime compatibility issues like we saw with 16 -> 18 and the sdks. Not exactly sure what that looks like yet. |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Removes the map of regions -> available lambda nodejs runtime versions
that previously was used for all custom resources vended in the aws-cdk.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license