Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove DEFAULT_CR_NODE_VERSION regional map #26665

Merged
merged 8 commits into from
Aug 22, 2023

Conversation

MrArnoldPalmer
Copy link
Contributor

Removes the map of regions -> available lambda nodejs runtime versions
that previously was used for all custom resources vended in the aws-cdk.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Removes the map of regions -> available lambda nodejs runtime versions
that previously was used for all custom resources vended in the aws-cdk.
@github-actions github-actions bot added the p2 label Aug 8, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 8, 2023 02:34
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 8, 2023
@rix0rrr
Copy link
Contributor

rix0rrr commented Aug 8, 2023

I guess we maybe don't need this map anymore, but wouldn't it be helpful to have a single place where we write down our default CR version? So that when Node 20 is released, we don't have to hunt and peck through our code to go and replace 18 -> 20 in 5820 different places, but can do it in one place?

@MrArnoldPalmer
Copy link
Contributor Author

Helpful yes but I think the mechanism should be different to allow migrating resources one by one in case of runtime compatibility issues like we saw with 16 -> 18 and the sdks. Not exactly sure what that looks like yet.

@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6ee4b3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 27b7201 into main Aug 22, 2023
8 checks passed
@mergify mergify bot deleted the chore/remove-cr-runtime-region-map branch August 22, 2023 15:38
@mergify
Copy link
Contributor

mergify bot commented Aug 22, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants