Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): grantConnect fails to deploy when no user is specified for instances with secret credentials #26647

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

lpizzinidev
Copy link
Contributor

Calling grantConnect on instances with secret credentials not specifying the user was causing the deploy to fail because the secret was not resolved.
This fix solves the bug.

Closes #26603.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team August 5, 2023 14:42
@github-actions github-actions bot added star-contributor [Pilot] contributed between 25-49 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 labels Aug 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 5, 2023
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I'm ready to ship it! However, I'm noticing your PR titles have not followed the contributing guide best practices at least a couple of times, so I'm going to set this to "Request changes" to make sure that you see this comment 😇


Please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log. In particular, if this is a bug fix, please describe the bug that was fixed, not the change you made. (See Contributing Guide, Pull Requests)

Specifically, this part:

Titles for feat and fix PRs end up in the change log. Think about what makes most sense for users reading the changelog while writing them.

  • feat: describe the feature (not the action of creating the commit or PR, for example, avoid words like "added" or "changed")
  • fix: describe the bug (not the solution)

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 7, 2023
@lpizzinidev lpizzinidev changed the title fix(rds): fixed grantConnect with no user specified for instances with secret credentials fix(rds): grantConnect fails to deploy when no user is specified for instances with secret credentials Aug 7, 2023
@lpizzinidev
Copy link
Contributor Author

@rix0rrr Thanks for the feedback 👍

@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 08c5a35
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 112b861 into aws:main Aug 8, 2023
8 checks passed
@mergify
Copy link
Contributor

mergify bot commented Aug 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p1 star-contributor [Pilot] contributed between 25-49 PRs to the CDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-rds): grantConnect fails if Instance has secret and user not specified
3 participants