Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(custom-resources): remove section about experimental SDKv3 support #26631

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Aug 4, 2023

AwsCustomResource now uses Node18/SDKv3 by default. This support is no longer experimental, and it does not require passing in different string values into the properties of the custom resource.

The V2 strings can be used to interact with the V3 SDK.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

`AwsCustomResource` now uses Node18/SDKv3 by default. This support is no
longer experimental, and it does not require passing in different string
values into the properties of the custom resource.

The V2 strings will be used to interact with the V3 SDK.
@rix0rrr rix0rrr requested a review from a team August 4, 2023 09:20
@aws-cdk-automation aws-cdk-automation requested a review from a team August 4, 2023 09:20
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 4, 2023
@github-actions github-actions bot added the p2 label Aug 4, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 4, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Aug 4, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9ebeab3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 4bf0762 into main Aug 4, 2023
11 checks passed
@mergify mergify bot deleted the huijbers/remove-aws-custom-resource-v3-section branch August 4, 2023 13:53
@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants