Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removes the requirement to have a domain name when using SSL certificates #26605

Conversation

nsmith-amplience
Copy link

This PR allows for domain names to be optional when creating a Cloudfront Distribution that has a certificate attached to it. As Cloudfront Distributions allow for domains to be transferred with the associate-alias command there are scenarios where having an SSL certificate attached without a domain are valid, and attaching the SSL certificate in the CDK creation phase minimises the amount of stack drift.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

…ing a certificate to a Distribution, this means you can provision a new Distribution and then use associate-alias to transfer a domain name
@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Aug 2, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team August 2, 2023 13:56
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 99a4e30
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@nsmith-amplience
Copy link
Author

Exemption Request

This PR is rolling back a previous change rather than implementing new functionality, it doesn't seem to meet the criteria in When are Integration Tests required.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Aug 2, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nsmith-amplience, before we can look at this PR the build needs to succeed. The current issue is:

aws-cdk-lib: aws-cloudfront/test/distribution.test.ts:514:1 - error TS1128: Declaration or statement expected.
aws-cdk-lib: 514 });
aws-cdk-lib:     ~
aws-cdk-lib: aws-cloudfront/test/distribution.test.ts:514:2 - error TS1128: Declaration or statement expected.
aws-cdk-lib: 514 });

@aws-cdk-automation
Copy link
Collaborator

This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Aug 31, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. p2 pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants