Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3): move notification destinations into their own module #2659

Merged
merged 7 commits into from
May 29, 2019
Merged

fix(s3): move notification destinations into their own module #2659

merged 7 commits into from
May 29, 2019

Commits on May 24, 2019

  1. fix(s3): move notification destinations into their own module 

    In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing S3
Notification Destinations into `@aws-cdk/aws-s3-notifications`.

Fixes #2445.

BREAKING CHANGE: using a Topic, Queue or Lambda as bucket notification
destination now requires an integration object from the
`@aws-cdk/aws-s3-notifications` package.
    @rix0rrr
    rix0rrr committed May 24, 2019
    Configuration menu
    Copy the full SHA
    3e864a9 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. Local state for 'foreach' script so it can be run in multiple clones … 

    …in parallel
    @rix0rrr
    rix0rrr committed May 28, 2019
    Configuration menu
    Copy the full SHA
    c710526 View commit details
    Browse the repository at this point in the history

  2. Fix

    @rix0rrr
    rix0rrr committed May 28, 2019
    Configuration menu
    Copy the full SHA
    b9eb42b View commit details
    Browse the repository at this point in the history

  3. Don't double-add permissions

    @rix0rrr
    rix0rrr committed May 28, 2019
    Configuration menu
    Copy the full SHA
    a6c8797 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into huijbers/s3-notific… 

    …ations
    @rix0rrr
    rix0rrr committed May 28, 2019
    Configuration menu
    Copy the full SHA
    2ad1a6a View commit details
    Browse the repository at this point in the history

  5. Lower branch coverage requirements

    @rix0rrr
    rix0rrr committed May 28, 2019
    Configuration menu
    Copy the full SHA
    e505472 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. Merge remote-tracking branch 'origin/master' into huijbers/s3-notific… 

    …ations
    @rix0rrr
    rix0rrr committed May 29, 2019
    Configuration menu
    Copy the full SHA
    8353e84 View commit details
    Browse the repository at this point in the history