Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(prlint): lint module with eslint #26486

Closed
wants to merge 2 commits into from
Closed

chore(prlint): lint module with eslint #26486

wants to merge 2 commits into from

Conversation

kaizencc
Copy link
Contributor

For some reason we don't lint this module, resulting in some ugly code conventions

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Jul 24, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 24, 2023 19:48
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jul 24, 2023
@kaizencc kaizencc mentioned this pull request Jul 24, 2023
Merged
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 24, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: cb9c7ca
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Jul 24, 2023
@kaizencc
chore(prlint): core PRs are always pr/needs-maintainer-review (#26487)
7f8eeb3 
Built the PR off of #26486 to hopefully avoid merge conflicts if we merge the other first

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@kaizencc
Copy link
Contributor Author

Merged in #26487 lol

@kaizencc kaizencc closed this Jul 24, 2023
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@kaizencc @bmoffatt
chore(prlint): core PRs are always pr/needs-maintainer-review (aws#…
ef392b6 
…26487)

Built the PR off of aws#26486 to hopefully avoid merge conflicts if we merge the other first

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colifran colifran colifran approved these changes

Assignees
No one assigned
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kaizencc @aws-cdk-automation @colifran