Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ecs): deployment alarm configurations are being added in isolated partitions #26458

Merged
merged 8 commits into from
Jul 21, 2023
Merged

fix(ecs): deployment alarm configurations are being added in isolated partitions #26458

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8c4f51c
chore(ecs): fix isolated partitions in deployment alarms validation
bvtujo Jul 20, 2023
c3b9e29
test: unit test for isolated partition behavior
bvtujo Jul 20, 2023
47bf8ce
Merge branch 'main' into chore/fix-isolated-partitions
mergify[bot] Jul 21, 2023
e5192c5
Merge branch 'main' into chore/fix-isolated-partitions
mrgrain Jul 21, 2023
7f7006e
Merge branch 'main' into chore/fix-isolated-partitions
mergify[bot] Jul 21, 2023
392b9f3
Merge branch 'main' into chore/fix-isolated-partitions
madeline-k Jul 21, 2023
7d5f601
Merge branch 'main' into chore/fix-isolated-partitions
mrgrain Jul 21, 2023
a25fdc8
cleanup
mrgrain Jul 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/aws-ecs/lib/base/base-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1367,7 +1367,7 @@ export abstract class BaseService extends Resource
}

private deploymentAlarmsAvailableInRegion(): boolean {
const unsupportedPartitions = ['aws-cn', 'aws-us-gov', 'aws-us-iso', 'aws-us-iso-b'];
const unsupportedPartitions = ['aws-cn', 'aws-us-gov', 'aws-iso', 'aws-iso-b'];
const currentRegion = RegionInfo.get(this.stack.resolve(this.stack.region));
if (currentRegion.partition) {
return !unsupportedPartitions.includes(currentRegion.partition);
Expand Down