Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(stepfunctions): add stateMachineRevisionId property to StateMachine #26443

Merged
merged 4 commits into from
Jul 20, 2023
Merged

feat(stepfunctions): add stateMachineRevisionId property to StateMachine #26443

merged 4 commits into from
Jul 20, 2023

Conversation

wong-a
Copy link
Contributor

@wong-a wong-a commented Jul 20, 2023

Expose stateMachineRevisionId as a readonly property to StateMachine whose value is a reference to the StateMachineRevisionId attribute of the underlying CloudFormation resource.

Closes #26440

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jul 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team July 20, 2023 04:24
aws-cdk-automation
aws-cdk-automation previously requested changes Jul 20, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@mrgrain mrgrain added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jul 20, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review July 20, 2023 08:37

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@wong-a wong-a requested a review from mrgrain July 20, 2023 16:04
mrgrain
mrgrain previously approved these changes Jul 20, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

evscott
evscott approved these changes Jul 20, 2023
View reviewed changes
Copy link

@evscott evscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@mergify mergify bot dismissed mrgrain’s stale review July 20, 2023 16:09

Pull request has been modified.

@wong-a wong-a requested a review from mrgrain July 20, 2023 17:31
@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4a113fd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3e47d1b into aws:main Jul 20, 2023
5 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@AlJohri AlJohri mentioned this pull request Jul 27, 2023
Open
2 tasks
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@wong-a @bmoffatt
feat(stepfunctions): add stateMachineRevisionId property to StateMach…
5e127b2 
…ine (aws#26443)

Expose `stateMachineRevisionId` as a readonly property to StateMachine whose value is a reference to the `StateMachineRevisionId` attribute of the underlying CloudFormation resource.

Closes aws#26440

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this pull request Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evscott evscott evscott approved these changes

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK feature-request A feature should be added or improved. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(stepfunctions): Expose StateMachineRevisionId attribute from StateMachine L2 construct
4 participants
@wong-a @aws-cdk-automation @mrgrain @evscott