Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decouple "synth" and "deploy" through cloud assemblies #2636

Merged
merged 31 commits into from
May 29, 2019

Commits on May 24, 2019

  1. interim

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    b5641a3 View commit details
    Browse the repository at this point in the history
  2. feat(cli): cloud assembly - decouple synth and deploy

    formalize the concept of a cloud assembly to allow decoupling "synth" and "deploy". the main
    motivation is to allow "deploy" to run in a controlled environment without needing to execute the app for security purposes.
    
    "cdk synth" now produces a self-contained assembly in the output directory, which we call a "cloud assembly". this directory includes synthesized templates (similar to current behavior) but also a "manifest.json" file and the asset staging directories.
    
    "cdk deploy -a <assembly-dir>" will now skip
    synthesis and will directly deploy the assembly.
    
    to that end, we modified the behavior of asset staging such that all synth output always goes to the output directory, which is by default `cdk.out` (can be set with `--output`). if there's a single template, it is printed to stdout, otherwise the name of output directory is printed.
    
    BREAKING CHANGE: apps created with this version cannot be deployed using a previous version of the CLI and vice versa. Both have to be >= 0.32.0.
    
    - @aws-cdk/cdk.App member synthesizeStack has been removed
    - @aws-cdk/cdk.App member synthesizeStacks has been removed
    - @aws-cdk/cdk.FileSystemStore has been removed
    - @aws-cdk/cdk.InMemoryStore has been removed
    - @aws-cdk/cdk.SynthesisSession member addBuildStep has been removed
    - @aws-cdk/cdk.SynthesisSession member store has been removed
    - @aws-cdk/cdk.FileSystemStoreOptions has been removed
    - @aws-cdk/cdk.ISessionStore has been removed
    - @aws-cdk/cdk.ISynthesisSession member addBuildStep has been removed
    - @aws-cdk/cdk.ISynthesisSession member store has been removed
    - @aws-cdk/cdk.ManifestOptions member legacyManifest has been removed
    - @aws-cdk/cdk.ResolveContext has been removed
    - @aws-cdk/cdk.SynthesisOptions member legacyManifest has been removed
    - @aws-cdk/cdk.SynthesisOptions member store has been removed
    - @aws-cdk/cx-api.BuildManifest has been removed
    - @aws-cdk/cx-api.BuildStep has been removed
    - @aws-cdk/cx-api.SynthesizeResponse has been removed
    - @aws-cdk/cx-api.SynthesizedStack has been removed
    - @aws-cdk/cx-api.BuildStepType has been removed
    - --interactive has been removed
    - --numbered has been removed
    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    971957b View commit details
    Browse the repository at this point in the history
  3. Merge remote-tracking branch 'origin/master' into benisrae/cloud-asse…

    …mbly
    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    2aac0f9 View commit details
    Browse the repository at this point in the history
  4. deprecate applets

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    a29f289 View commit details
    Browse the repository at this point in the history
  5. a few test fixes

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    76d4abc View commit details
    Browse the repository at this point in the history
  6. update more tests

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    f49ef1b View commit details
    Browse the repository at this point in the history
  7. fix lambda test

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    27323a5 View commit details
    Browse the repository at this point in the history
  8. fix codecommit test

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    09a7b2f View commit details
    Browse the repository at this point in the history
  9. fix a few more tests

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    2c6e184 View commit details
    Browse the repository at this point in the history
  10. fix decdk test

    Elad Ben-Israel committed May 24, 2019
    Configuration menu
    Copy the full SHA
    e004555 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2019

  1. add missing package.lock

    Elad Ben-Israel committed May 26, 2019
    Configuration menu
    Copy the full SHA
    d4fb3c0 View commit details
    Browse the repository at this point in the history
  2. add semver back

    Elad Ben-Israel committed May 26, 2019
    Configuration menu
    Copy the full SHA
    7d42d2f View commit details
    Browse the repository at this point in the history

Commits on May 27, 2019

  1. cli: fail if unable to resolve aws region

    Elad Ben-Israel committed May 27, 2019
    Configuration menu
    Copy the full SHA
    d0f6ae0 View commit details
    Browse the repository at this point in the history
  2. cli: support relative asset paths

    Elad Ben-Israel committed May 27, 2019
    Configuration menu
    Copy the full SHA
    4f7e680 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2019

  1. add "deprecated" to applet-js package.json

    Elad Ben-Israel committed May 28, 2019
    Configuration menu
    Copy the full SHA
    2962c9b View commit details
    Browse the repository at this point in the history
  2. update error message when --output is undefined

    Elad Ben-Israel committed May 28, 2019
    Configuration menu
    Copy the full SHA
    6cc76d1 View commit details
    Browse the repository at this point in the history
  3. rename variable in test.assertions

    Elad Ben-Israel committed May 28, 2019
    Configuration menu
    Copy the full SHA
    d3d3e11 View commit details
    Browse the repository at this point in the history
  4. move jest config to package.json

    Elad Ben-Israel committed May 28, 2019
    Configuration menu
    Copy the full SHA
    e2cbec1 View commit details
    Browse the repository at this point in the history
  5. misc

    - return CloudAssembly from app.run()
    - change cloud assembly version to 0.33.0
    - make stack trace optional in metadata
    Elad Ben-Israel committed May 28, 2019
    Configuration menu
    Copy the full SHA
    ee39a2e View commit details
    Browse the repository at this point in the history

Commits on May 29, 2019

  1. add support for assets in testStack

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    8f67b13 View commit details
    Browse the repository at this point in the history
  2. save & emit token creation stack traces

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    a4c776a View commit details
    Browse the repository at this point in the history
  3. app.isApp

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    9fe08a6 View commit details
    Browse the repository at this point in the history
  4. node.root

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    3330736 View commit details
    Browse the repository at this point in the history
  5. fail if referencing tokens across apps

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    74ab7aa View commit details
    Browse the repository at this point in the history
  6. fix test.code

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    caac4b9 View commit details
    Browse the repository at this point in the history
  7. Merge remote-tracking branch 'origin/master' into benisrae/cloud-asse…

    …mbly
    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    09e1543 View commit details
    Browse the repository at this point in the history
  8. fix some build issues

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    ebe7109 View commit details
    Browse the repository at this point in the history
  9. do not import SynthUtils

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    c0a7b4f View commit details
    Browse the repository at this point in the history
  10. �SynthUtil: always synth against root

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    aea33fe View commit details
    Browse the repository at this point in the history
  11. fix various tests

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    90c1124 View commit details
    Browse the repository at this point in the history
  12. fix elbv2 tests

    Elad Ben-Israel committed May 29, 2019
    Configuration menu
    Copy the full SHA
    d40b6de View commit details
    Browse the repository at this point in the history