-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(route53-targets): move Alias Targets into their own package #2617
Conversation
In accordance with new guidelines, we're centralizing cross-service integrations into their own package. In this case, centralizing Route53 Alias Targets into `@aws-cdk/aws-route53-targets`. Fixes #2448. BREAKING CHANGE: using a CloudFront Distribution or an ELBv2 Load Balancer as an Alias Record Target now requires an integration object from the `@aws-cdk/aws-route53-targets` package.
@@ -134,7 +134,8 @@ | |||
"jsii-reflect": "^0.10.5", | |||
"jsonschema": "^1.2.4", | |||
"yaml": "1.5.0", | |||
"yargs": "^13.2.2" | |||
"yargs": "^13.2.2", | |||
"@aws-cdk/aws-route53-targets": "^0.31.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hardcore nitpicking/bikeshedding, but I'd really like it if we could keep this list sorted alphabetically. Feel free to ignore though (it's not so important in the grand scheme of things).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much cleaner. I am happy with this!
In accordance with new guidelines, we're centralizing cross-service
integrations into their own package. In this case, centralizing
Route53 Alias Targets into
@aws-cdk/aws-route53-targets
.Fixes #2448.
BREAKING CHANGE: using a CloudFront Distribution or an ELBv2
Load Balancer as an Alias Record Target now requires an integration
object from the
@aws-cdk/aws-route53-targets
package.Pull Request Checklist
design
folderBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.