Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): deployment continues if ECR asset fails to build or publish #26060

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 20, 2023

Fixes #26048, fixes #25827.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr requested a review from a team June 20, 2023 16:41
@gitpod-io
Copy link

gitpod-io bot commented Jun 20, 2023

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 20, 2023
@github-actions github-actions bot added bug This issue is a bug. effort/medium Medium work item – several days of effort p1 labels Jun 20, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 20, 2023 16:42
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Jun 20, 2023
Copy link
Contributor

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some tests. They are semi-redundant in that they do not directly test the added code. Instead, they show that if buildSingleAsset or publishSingleAsset did throw an error, then that error would be properly reflected in the work graph. There's probably a better way to directly test, but this looks like the simplest path forward that still shows that the error messages will be sufficient.

@kaizencc kaizencc added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested and removed pr/needs-cli-test-run This PR needs CLI tests run against it. labels Jun 21, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 21, 2023 04:39

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 147d20d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 37caaab into main Jun 21, 2023
@mergify mergify bot deleted the huijbers/fix-asset-failure branch June 21, 2023 05:05
@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/cli-integ-tested Assert that any CLI changes have been integ tested pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
3 participants