-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(servicecatalog): Make possible to have assets in different products in the same portfolio #26039
Conversation
Hi Aws Cdk Team! Could you please run integration test for me? When I am doing it on my own, I am getting this error (region seems to be set in env variables): ❌ Building assets failed: Error: Building Assets Failed: Error: Could not assume role in target account using current credentials (which are for account ....) Inaccessible host: 'sts.test-region.amazonaws.com' at port 'undefined'. This service may not be available in the 'test-region' region. . Please make sure that this role exists in the account. If it doesn't exist, (re)-bootstrap the environment with the right '--trust', using the latest version of the CDK CLI. But I deployed stack manually and it has worked. Thank you in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request
. Additionally, if clarification is needed add Clarification Request
to a comment.
Exemption Request |
@@ -30,7 +30,7 @@ export class ProductStackSynthesizer extends cdk.StackSynthesizer { | |||
cdk.Annotations.of(parentStack).addWarning('[WARNING] Bucket Policy Permissions cannot be added to' + | |||
' referenced Bucket. Please make sure your bucket has the correct permissions'); | |||
} | |||
this.bucketDeployment = new BucketDeployment(parentStack, 'AssetsBucketDeployment', { | |||
this.bucketDeployment = new BucketDeployment(parentStack, `${cdk.Names.uniqueId(this.boundStack)}-AssetsBucketDeployment`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the bucket deployment can be shared within the same stack what if we did something like this:
this.bucketDeployment = parentStack.tryFindChild('AssetsBucketDeployment') ?? new BucketDeployment(...)
It looks like this test might not be able to work with the update workflow. You can run the test with |
@ViktarKhomich Happy to run the integ tests once you've addressed the previously received feedback. |
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
… in the same portfolio (aws#25189) Check for the existing AssetDeploymentBucket and if it is, use it otherwise create a new one
Hi @ViktarKhomich, are you still available to address feedback? We're happy to run the integ tests once you've addressed the previously received feedback. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
Hi @kaizencc, yes, I am still available. I did changes regarding the comment above, but PR seems to be closed automatically again. Can we re-open it? Thank you! |
Reopened -- please make sure that the build succeeds and that you can merge from main to get the latest changes as well @ViktarKhomich |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
We have a label, `pr-linter/do-not-close` that has not been doing its job. See #26039. It is because we are expecting a comma-separated-list, without spaces: https://github.com/rix0rrr/close-stale-prs/blob/ffeb148adbaf7402e77bc4eafce8ed3d3c40f29c/src/index.ts#L22 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Okay I think I fixed the |
Closing in favor of #26885 Thanks for you effort! Even though it didn't get merged in the end, it was useful for the other PR. |
fix(servicecatalog): Make possible to have assets in different products in the same portfolio (#25189)
Currently it's not possible to have assets (ex. lambdas) in different products in the same portfolio. The reason for that is that asset bucket will be deployed
within the portfolio stack and name for its deployment is hardcoded what leads to the exception 'There is already a Construct with name' at synth step.
Closes #25189
Exemption Request
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license