chore(apprunner): add validation cpu and memory for app runner

[go-to-k]

This PR adds the same validation for the App Runner's CPU and Memory values as CloudFormation's input patterns.

Closes #25872

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[go-to-k]

I reverted this commit for the following reasons.

• Make it easier to understand even if it is somewhat redundant.
• Less mistakes when dealing with new specs.
  • e.g. even in the case of adding only the enum option and forgetting to add it to the of() validation parameter, the test can still detect the error.
• Even static variable definitions are secured by defining them through a safe of() with validation.

[go-to-k]

The AWS CodeBuild CI Report failed with internal health check errors...

time="2023-06-07T09:58:28.630630240Z" level=error msg="healthcheck failed fatally"

#25877 (comment)

[go-to-k]

I would try to make it more type safe, but guess what?

It is a union type of input-able values, and since it is string-compatible, it does not affect existing implementations and is not a destructive change.

9968af0

If not, I will revert to the previous commit.

Considering languages other than TypeScript (e.g. Python), maybe the previous one is better?

[otaviomacedo]

As you have guessed, this doesn't work for languages other than TypeScript. Take a look at:

aws-cdk/packages/@aws-cdk/aws-apprunner-alpha/lib/service.ts

Lines 31 to 55 in 75d1853

	export class Cpu {
	/**
	* 0.25 vCPU
	*/
	public static readonly QUARTER_VCPU = Cpu.of('0.25 vCPU');
	/**
	* 0.5 vCPU
	*/
	public static readonly HALF_VCPU = Cpu.of('0.5 vCPU');
	/**
	* 1 vCPU
	*/
	public static readonly ONE_VCPU = Cpu.of('1 vCPU')
	/**
	* 2 vCPU
	*/
	public static readonly TWO_VCPU = Cpu.of('2 vCPU')
	/**
	* 4 vCPU
	*/
	public static readonly FOUR_VCPU = Cpu.of('4 vCPU')

[go-to-k]

@otaviomacedo

Thanks for your review. I reverted to the previous commit.

So please review again.

[otaviomacedo]

Same kind of solution could be used here.

[go-to-k]

I reverted same as above comments.

Pull request has been modified.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: f8730af
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).