Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): ENOENT during asset publishing #25869

Merged
merged 6 commits into from
Jun 6, 2023
Merged

fix(cli): ENOENT during asset publishing #25869

merged 6 commits into from
Jun 6, 2023

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Jun 6, 2023

There was still a TOCTOU error in the file asset publishing, which could lead to ENOENT: no such file or directory when assets were being published in parallel.

The whole if (fileExists) { delete; } logic was actually not necessary, as fs.rename will atomically overwrite existing files already, so we can just call it directly.

Closes #25293.
Closes #25380


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

There was still a TOCTOU error in the file asset publishing, which could
lead to `ENOENT: no such file or directory` when assets were being published
in parallel.

The whole `if (fileExists) { delete; }` logic was actually not
necessary, as `fs.rename` will atomically overwrite existing files
already, so we can just call it directly.

Closes #25293.
@rix0rrr rix0rrr requested a review from a team June 6, 2023 11:30
@gitpod-io
Copy link

gitpod-io bot commented Jun 6, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team June 6, 2023 11:30
@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Jun 6, 2023
@github-actions github-actions bot added the p2 label Jun 6, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 6, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Jun 6, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 6, 2023 11:34

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 44054d9
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 1668dbd into main Jun 6, 2023
@mergify mergify bot deleted the huijbers/cli-enoent branch June 6, 2023 17:06
@mergify
Copy link
Contributor

mergify bot commented Jun 6, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(cdk-assets): cdk depoly --concurrency N still sometimes causes ENOENT error to occur
3 participants