Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(ecs): fix a property doc in ExecuteCommandLogConfiguration #25856

Merged
merged 4 commits into from
Jun 13, 2023
Merged

docs(ecs): fix a property doc in ExecuteCommandLogConfiguration #25856

merged 4 commits into from
Jun 13, 2023

Conversation

go-to-k
Copy link
Contributor

@go-to-k go-to-k commented Jun 5, 2023

As mentioned in #25855, a doc of the s3EncryptionEnabled in the ExecuteCommandLogConfiguration interface is wrong.

Closes #25855

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 5, 2023

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 5, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 5, 2023 16:54
@github-actions github-actions bot added the p2 label Jun 5, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 5, 2023
otaviomacedo
otaviomacedo previously approved these changes Jun 8, 2023
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Jun 8, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@go-to-k
Copy link
Contributor Author

go-to-k commented Jun 9, 2023

@otaviomacedo

Thank you for your approvement, but the CodeBuid CI failed with following messages.

time="2023-06-08T15:39:17.422543152Z" level=error msg="healthcheck failed fatally"

Should I be concerned about this ?

@mergify mergify bot dismissed otaviomacedo’s stale review June 12, 2023 13:28

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d90dffa into aws:main Jun 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fda384e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@go-to-k go-to-k deleted the docs/fix-ecs-exec-cmd-log-cfg-docs branch June 13, 2023 09:40
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecs: wrong description for a property in ExecuteCommandLogConfiguration
4 participants
@go-to-k @aws-cdk-automation @otaviomacedo @corymhall