Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: avoid importing directly from 'aws-cdk-lib' in alpha packages #25802

Merged
merged 6 commits into from
Jun 12, 2023
Merged

chore: avoid importing directly from 'aws-cdk-lib' in alpha packages #25802

merged 6 commits into from
Jun 12, 2023

Conversation

thdxr
Copy link
Contributor

@thdxr thdxr commented Jun 1, 2023

now that aws-cdk-lib exports the core sub-package, the alpha packages should import from there instead of aws-cdk-lib

otherwise any usage of these alpha packages will cause node to traverse every single file in aws-cdk-lib

@gitpod-io
Copy link

gitpod-io bot commented Jun 1, 2023

@github-actions github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jun 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team June 1, 2023 01:05
aws-cdk-automation
aws-cdk-automation previously requested changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@thdxr thdxr changed the title Avoid importing directly from 'aws-cdk-lib' in alpha packages chore: avoid importing directly from 'aws-cdk-lib' in alpha packages Jun 1, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review June 1, 2023 01:11

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@WarrenBuffering
Copy link

lgtm

@snewell92
Copy link

@mrgrain this improves upon #25543 if you wanna take a look 😊

@corymhall
Copy link
Contributor

@thdxr thanks for picking this up! Looks like there are just some linting issues with the build. Once it is passing ping me and I'll approve.

@thdxr
Copy link
Contributor Author

thdxr commented Jun 4, 2023

I cannot figure out how to run the linters autofix

there seems to be tsconfig files missing in all of these packages that the linter is looking for - am i doing something wrong?

@corymhall
Copy link
Contributor

I cannot figure out how to run the linters autofix

there seems to be tsconfig files missing in all of these packages that the linter is looking for - am i doing something wrong?

You should be able to run yarn build --fix in the package.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jun 10, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: fe6c97a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit a7ae5a4 into aws:main Jun 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 12, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc kaizencc mentioned this pull request Jun 16, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jun 19, 2023
@kaizencc
chore(eslint-plugin): linter chokes on aws-cdk-lib/core import (#26022)
a278fa7 
#25802 changed imports in alpha modules from `aws-cdk-lib` to `aws-cdk-lib/core`.

Not sure how that got past the linter in the first place, but my linter is choking on this because `aws-cdk-lib/core` does not have a `package.json`.

```bash
Error: ENOENT: no such file or directory, open '<path>/aws-cdk/packages/aws-cdk-lib/core/package.json'
```

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corymhall corymhall corymhall approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thdxr @WarrenBuffering @snewell92 @corymhall @aws-cdk-automation