Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(eks): improve eks doc for console access #25606

Merged
merged 13 commits into from
Jul 26, 2023
Merged

chore(eks): improve eks doc for console access #25606

merged 13 commits into from
Jul 26, 2023

Conversation

pahud
Copy link
Contributor

@pahud pahud commented May 16, 2023

Improve the EKS doc in terms of the console access.

Closes #18843

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 16, 2023

@aws-cdk-automation aws-cdk-automation requested a review from a team May 16, 2023 05:04
@github-actions github-actions bot added bug This issue is a bug. p2 labels May 16, 2023
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label May 16, 2023
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 16, 2023
@pahud pahud marked this pull request as draft May 16, 2023 14:08
@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@pahud
Copy link
Contributor Author

pahud commented Jul 13, 2023

Please do not merge this PR for now. I will wait for the next release and validate this again with eks with k8s 1.27. If everything is good, I'll change this PR from draft to ready to review.

@kaizencc kaizencc added the pr/do-not-merge This PR should not be merged at this time. label Jul 13, 2023
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jul 13, 2023
@mrgrain
Copy link
Contributor

mrgrain commented Jul 25, 2023

@pahud Can you progress this PR now?

@pahud pahud marked this pull request as ready for review July 25, 2023 14:12
@pahud pahud removed the pr/do-not-merge This PR should not be merged at this time. label Jul 25, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 4c9191a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3baffd8 into aws:main Jul 26, 2023
6 of 7 checks passed
@mergify
Copy link
Contributor

mergify bot commented Jul 26, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@pahud @bmoffatt
chore(eks): improve eks doc for console access (aws#25606)
e13ed8f 
Improve the EKS doc in terms of the console access.

Closes aws#18843

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviomacedo otaviomacedo otaviomacedo approved these changes

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(eks): missing access to Kubernetes objects on EKS cluster creation
5 participants
@pahud @mrgrain @aws-cdk-automation @otaviomacedo @kaizencc