-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(region-info): register eu-central-2, fix firehose cidr blocks for ap-south-2, eu-south-2, me-central-1 #25572
Merged
Merged
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
3eb137b
add available info for eu-central-2 to fact-tables.ts
sumupitchayan a1f0158
Merge branch 'main' into sumughan/register-eu-central-2
sumupitchayan 06fea99
run integ tests on @aws-cdk, no changes from aws-cdk-lib
sumupitchayan b778eb9
update region-info snapshot
sumupitchayan 28fb5d9
Merge branch 'main' into sumughan/register-eu-central-2
sumupitchayan 195690c
Merge branch 'main' into sumughan/register-eu-central-2
sumupitchayan ac1f7e4
comment out metadata resource for ap-south-2 and eu-central-2
sumupitchayan 213992f
Merge branch 'main' into sumughan/register-eu-central-2
sumupitchayan 79bbf5a
update region info unit test snapshot
sumupitchayan 6600001
Merge branch 'main' into sumughan/register-eu-central-2
sumupitchayan 6ba81ce
fix cidr value for ap-south-2
sumupitchayan 03c8aed
fix cidr value for eu-central-2
sumupitchayan a39909c
fix cidr value for eu-south-2
sumupitchayan 2b20964
Merge branch 'sumughan/register-eu-central-2' of https://github.com/a…
sumupitchayan 43b21f9
fix cidr value for me-central-1
sumupitchayan c77fee7
update integ snapshots on packages/@aws-cdk
sumupitchayan 5fdca3d
fix me-central-1 cidr block value again
sumupitchayan f0f2ff0
revert change to FEATURE_FLAGS.md
sumupitchayan 4996ab8
rerun integ tests on @aws-cdk
sumupitchayan cbf727b
Merge branch 'main' into sumughan/register-eu-central-2
sumupitchayan e93637a
Merge branch 'main' into sumughan/register-eu-central-2
mergify[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...test/kinesis-firehose/integ.firehose-put-record-action.js.snapshot/test-stack.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...alpha/test/integ.delivery-stream.js.snapshot/aws-cdk-firehose-delivery-stream.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...ream.source-stream.js.snapshot/aws-cdk-firehose-delivery-stream-source-stream.assets.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't look right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same for
eu-south-2
by the way, although that's not your PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And
me-central-1
and a bunch of others. I think we need to refactor how the firehose cidr block fact works.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea this does look strange. I'll update these by removing the
/26
from the numbers