Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eks): support for Kubernetes version 1.26 #25088

Merged
merged 3 commits into from
Apr 20, 2023
Merged

feat(eks): support for Kubernetes version 1.26 #25088

merged 3 commits into from
Apr 20, 2023

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Apr 12, 2023 •
edited
Loading

Depends on cdklabs/awscdk-asset-kubectl#242

image

Closes #25087

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added p2 distinguished-contributor [Pilot] contributed 50+ PRs to the CDK labels Apr 12, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team April 12, 2023 18:03
aws-cdk-automation
aws-cdk-automation previously requested changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 and removed p2 labels Apr 12, 2023
@robertd robertd force-pushed the k8s-1.26 branch 2 times, most recently from 72a416a to 26284e2 Compare April 14, 2023 22:10
@robertd robertd marked this pull request as ready for review April 14, 2023 22:10
@robertd
Copy link
Contributor Author

robertd commented Apr 15, 2023

@kaizencc this PR is ready for your review. TY!

@kaizencc
Copy link
Contributor

Depends on getting the NuGet release out -- its currently failing for all kubectl versions: https://github.com/cdklabs/awscdk-asset-kubectl/actions/runs/4624100115

@robertd
Copy link
Contributor Author

robertd commented Apr 17, 2023

@kaizencc Is that something that's being worked on?

Response status code does not indicate success: 403 (The specified API key is invalid, has expired, or does not have permission to access the specified package.).

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

2 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@gitpod-io
Copy link

gitpod-io bot commented Apr 20, 2023

@kaizencc kaizencc added pr-linter/exempt-test The PR linter will not require test changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Apr 20, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review April 20, 2023 15:46

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 6aa9212
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 20, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 792e3f2 into aws:main Apr 20, 2023
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
@pahud pahud mentioned this pull request Jul 6, 2023
Merged
mergify bot pushed a commit that referenced this pull request Jul 7, 2023
@pahud
feat(eks): support eks with k8s 1.27 (#25897)
fdd3309 
Similar to #25088, this PR add eks with k8s 1.27 support.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
tmokmss pushed a commit to tmokmss/aws-cdk that referenced this pull request Jul 9, 2023
@pahud @tmokmss
feat(eks): support eks with k8s 1.27 (aws#25897)
f9d6180 
Similar to aws#25088, this PR add eks with k8s 1.27 support.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
@pahud @bmoffatt
feat(eks): support eks with k8s 1.27 (aws#25897)
dd2374e 
Similar to aws#25088, this PR add eks with k8s 1.27 support.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
distinguished-contributor [Pilot] contributed 50+ PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-eks): support v1.26
3 participants
@robertd @kaizencc @aws-cdk-automation