Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(s3-deployment): physical id not set during failure scenario #24428

Merged
merged 4 commits into from
Mar 29, 2023
Merged

fix(s3-deployment): physical id not set during failure scenario #24428

merged 4 commits into from
Mar 29, 2023

Conversation

garyaparker
Copy link
Contributor

Send the correct physical id to CloudFormation to prevent unintended object deletion during rollback.

Closes #22670

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@garyparker-lm
fix: set correct cfn phsyical id during failure scenario
ace8559 
Send the correct physical id to CloudFormation to prevent unintended object
deletion during rollback.
@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p1 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 2, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 2, 2023 17:40
aws-cdk-automation
aws-cdk-automation previously requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@garyaparker
Copy link
Contributor Author

Exemption Request

This fix addresses an issue in the lambda source code. I don't believe this would be captured in an integration test but am willing to contribute one if that is not the case.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Mar 2, 2023
@aws aws deleted a comment from aws-cdk-automation Mar 28, 2023
@TheRealAmazonKendra TheRealAmazonKendra added @aws-cdk/integ-tests and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Mar 28, 2023
@TheRealAmazonKendra
Copy link
Contributor

Added exemption. I'm not sure how you're integ test this.

@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed @aws-cdk/integ-tests labels Mar 28, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 28, 2023 21:27

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 28, 2023

update

❌ Base branch update has failed

refusing to allow a GitHub App to create or update workflow .github/workflows/auto-approve.yml without workflows permission
err-code: C2AE6

@TheRealAmazonKendra TheRealAmazonKendra changed the title fix: set correct cfn phsyical id during failure scenario fix(s3-deployment): physical id not set during failure scenario Mar 29, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws aws deleted a comment from mergify bot Mar 29, 2023
@aws aws deleted a comment from mergify bot Mar 29, 2023
@aws aws deleted a comment from mergify bot Mar 29, 2023
@aws aws deleted a comment from mergify bot Mar 29, 2023
@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio unqueue

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

unqueue

☑️ The pull request is not queued

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 5bc47de
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit be4be99 into aws:main Mar 29, 2023
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws_s3_deployment: BucketDeployment is deleted if custom resource lambda fails during update
4 participants
@garyaparker @TheRealAmazonKendra @aws-cdk-automation @garyparker-lm