Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 2.66.1 #24279

Closed
wants to merge 10 commits into from
Closed

chore(release): 2.66.1 #24279

wants to merge 10 commits into from

Conversation

Naumel
Copy link
Contributor

@Naumel Naumel commented Feb 22, 2023

See CHANGELOG

stefanfreitag and others added 10 commits February 22, 2023 20:51
Add support for Apache Kafka versions 3.1.1, 3.2.0 and 3.3.1 in Amazon MSK.

Announcements:
- [3.1.1 and 3.2.0](https://aws.amazon.com/about-aws/whats-new/2022/06/amazon-msk-adds-support-apache-kafka-version-3-1-1-3-2-0/) (Posted On: Jun 22, 2022)
- [3.3.1](https://aws.amazon.com/about-aws/whats-new/2022/10/amazon-msk-support-apache-kafka-version-3-3-1) (Posted On: Oct 26, 2022)

Closes #23899 
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
When using `Vpc.fromLookup()`, a call may be made to determine whether a VPN Gatway is attached. This call can be undesirable, for example when the lookup role does not have permissions to make this call. This adds a flag to allow opting out of VPN Gateways being queried to alleviate this requirement.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This is to help vet that the new release line correctly interoperates with `jsii@1.x` before issuing a stable release.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
A recent change in a dependency we use to enforce the order of imports included a small update  to sort import from `./` before `../`.
We previously warned about violations of this rule, but did not enforce it.
This frequently causes files unrelated to a change being updated.

With this change I've updated all violations of this rule and the lint step is now free of warnings.
Most of these updates where automated, by passing `--fix` to the lint command.
For a few I had to manual resolve the problem.
In a small number of cases the import order could not be changed without causing a test failure.
For these I have just disabled the rule per line/block and did not investigate further.

This changes also updates the `import/order` rule to `error` to avoid any future issues.

Existing PRs will be fine, we enforce update from main anyway.
In some circumstances where new imports are added this will cause conflicts and require manual intervention.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This PR fixes the integ tests errors in aws-eks and addresses the following issues:

`integ.alb-controller.ts` has `runAsNonRoot` error and should define a non-root user in securityContext of the pod definition to ensure successful k8s deployment.

`integ.eks-service-account-sdk-call.ts` should define a non-root user as well and increase the timeout of `BucketPinger` from the default 1 min to 3 min as the deployment could take up to 2 minutes or more. The base docker image from docker hub for this test has been replaced with the same image in ECR public to avoid potential throttling.

I have manually run the two integ tests in my account and both successfully deploy with no error now.

Closes #24266

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
MagagedRule up-to-date whenever possible.

fixes #21896



----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Construct Runtime Dependencies:

* [ ] This PR adds new construct runtime dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-construct-runtime-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Closes #24243.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@gitpod-io
Copy link

gitpod-io bot commented Feb 22, 2023

@github-actions github-actions bot added the p2 label Feb 22, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team February 22, 2023 20:02
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 22, 2023
@Naumel Naumel changed the title Patch/v2.66.1 chore(release): 2.66.1 Feb 22, 2023
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation added the pr/needs-cli-test-run This PR needs CLI tests run against it. label Feb 22, 2023
@Naumel Naumel added the pr/no-squash This PR should be merged instead of squash-merging it label Feb 22, 2023
@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ CLI code has changed. A maintainer must run the code through the testing pipeline (git fetch origin pull/24279/head && git push -f origin FETCH_HEAD:test-main-pipeline), then add the 'pr-linter/cli-integ-tested' label when the pipeline succeeds.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@Naumel
Copy link
Contributor Author

Naumel commented Feb 22, 2023

This does not look right, it should contain just the fix.

@Naumel Naumel closed this Feb 22, 2023
@Naumel Naumel deleted the patch/v2.66.1 branch February 22, 2023 20:14
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: ce4523a
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2 pr/needs-cli-test-run This PR needs CLI tests run against it. pr/no-squash This PR should be merged instead of squash-merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants