feat(amplify): Add platform property to Amplify App #24078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
feature-request
aws-cdk-automation
requested changes
Feb 8, 2023
kevinold
changed the title
kevinold
force-pushed
the
kevinold/amplify-add-platform
branch
from
e54c6ee to
2bd1c4f
Compare
peterwoodworth
suggested changes
Feb 8, 2023
There was a problem hiding this comment.
Hey @kevinold, thanks for the PR, it looks great! We just need some integration tests to verify that these deploy 🙂
Adds AppPlatforms enum for WEB, WEB_COMPUTE or WEB_DYNAMIC Adds platform property to AppProps Passes platform property to declared Amplify app fixes aws#24076
kevinold
force-pushed
the
kevinold/amplify-add-platform
branch
from
2bd1c4f to
99bb439
Compare
|
@peterwoodworth Great, just added |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This duplicates work already done in an open PR. |
|
@TheRealAmazonKendra Great! Closing in favor of #23818 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds AppPlatforms enum for WEB, WEB_COMPUTE or WEB_DYNAMIC
Adds platform property to AppProps
Passes platform property to declared Amplify app
Closes #24076.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license