fix(core): messages are displayed multiple times per construct

[Styerp]

Annotations added many times clog terminal space and make debugging difficult. Deduplicate annotations based on the message.

Closes #9565.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[aws-cdk-automation]

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

[Styerp]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If there's an integration test that should capture this behavior, I don't see it. Happy to update it.

[TheRealAmazonKendra]

Hmmm. I don't thiiiiiiiink there's a good integ test to add here but, can you write a quick repro of a manual test you ran for this and then provide the output? The unit test is good but I'm overly cautious about all the things all the time.

[Styerp]

Makes sense. I'll use the original bug report's repro steps.

EKS Integ synth pre-change:

(system)(annotate) ☆ npx cdk synth -a 'ts-node test/integ.eks-cluster.ts'                                                                                  (/Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks (14))(07:39)
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
Successfully synthesized to /Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks/cdk.out
Supply a stack id (aws-cdk-eks-cluster-test, aws-cdk-eks-cluster/DefaultTest/DeployAssert) to display its template.

(system)(annotate*) ☆ git log -n 1                                                                                                                         (/Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks (14))(07:40)
commit 0b20bc5f2899c205a2a4a81d2d3b57c6dd4e6a64 (HEAD -> annotate, origin/main, origin/HEAD, main)
Merge: 2b6a0bede4 83d1685c97
Author: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Date:   Sat Feb 4 23:36:21 2023 +0000

    chore(merge-back): 2.63.2 (#24012)
    
    See [CHANGELOG](https://github.com/aws/aws-cdk/blob/merge-back/2.63.2/CHANGELOG.md)
(system)(annotate*) ☆                                                                                                                                      (/Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks (14))(07:42)

EKS Integ test synth w/ change (branch modification was only chmod +x test/integ.eks-cluster.ts):

(system)(annotate*) ☆ npx cdk synth -a 'ts-node test/integ.eks-cluster.ts'                                                                                 (/Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks (14))(07:02)
[Warning at /aws-cdk-eks-cluster-test/Cluster/Nodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/NodesArm/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/BottlerocketNodes/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
[Warning at /aws-cdk-eks-cluster-test/Cluster/spot/InstanceSecurityGroup] Ignoring Egress rule since 'allowAllOutbound' is set to true; To add customized rules, set allowAllOutbound=false on the SecurityGroup
Successfully synthesized to /Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks/cdk.out
Supply a stack id (aws-cdk-eks-cluster-test, aws-cdk-eks-cluster/DefaultTest/DeployAssert) to display its template.

(system)(annotate*) ☆ git log -n 1                                                                                                                         (/Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks (14))(07:04)
commit 508ca84dd884d4f9101ed207b027269f08731cac (HEAD -> annotate, origin/annotate)
Author: Patrick Styer <styerp@amazon.com>
Date:   Sat Feb 4 20:38:43 2023 -0800

    fix(core): messages are displayed multiple times per construct
(system)(annotate*) ☆                                                                                                                                      (/Users/styerp/aws-cdk/packages/@aws-cdk/aws-eks (14))(07:04)

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: eab4774
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).