Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java init template #229

Merged
merged 3 commits into from
Jul 3, 2018
Merged

Java init template #229

merged 3 commits into from
Jul 3, 2018

Commits on Jul 3, 2018

  1. aws-cdk-java: clean up pom.xml and include in deployed maven repo 

    Include the pom.xml file in the maven repo, so that transitive dependencies will be respected.

This also required us to clean up the file and not include the path to the jsii-runtime repo. Instead, we simply deploy it into ~/.m2 during `./generate.sh`.

Not ideal, but works for now. When jsii is published to Maven Central, this is all going to go away, so trying to not over-engineer it.
    Elad Ben-Israel committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    20438af View commit details
    Browse the repository at this point in the history

  2. cdk-init template for Java app 

    The template includes a java shim for the toolkit called "app.sh". The shim depends on a file `.classpath.txt` that's generated by maven during build. It points to `target/classes` for classpath. This supports a workflow where you can iterate in the IDE (and run unit tests), but then go to the command line to execute the toolkit, and you will target the same classes the IDE compiled.

BETA: the template includes a pom.xml file that depends on `~/.cdk/repo/maven` as a pragmatic solution for beta. There's value in adding the repository in the pom.xml file directly as this gets us seamless IDE experience that works out of the box.
    Elad Ben-Israel committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    1cc546d View commit details
    Browse the repository at this point in the history

  3. A couple of CR fixes

    Elad Ben-Israel committed Jul 3, 2018
    Configuration menu
    Copy the full SHA
    f3c926b View commit details
    Browse the repository at this point in the history