Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): add k8s version 1.22, 1.23, deprecate 1.18, 1.19, 1.20 #22544

Closed
wants to merge 1 commit into from

Conversation

cgarvis
Copy link
Contributor

@cgarvis cgarvis commented Oct 18, 2022

EKS supported versions:

* 1.23
* 1.22
* 1.21
* 1.20

https://docs.aws.amazon.com/eks/latest/userguide/kubernetes-versions.html

@gitpod-io
Copy link

gitpod-io bot commented Oct 18, 2022

@github-actions github-actions bot added the p2 label Oct 18, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team October 18, 2022 16:03
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 18, 2022
@cgarvis cgarvis added p1 and removed p2 labels Oct 18, 2022
@madeline-k madeline-k changed the title chore(eks): add k8s version 1.22, 1.23, deprecate 1.18, 1.19, 1.20 feat(eks): add k8s version 1.22, 1.23, deprecate 1.18, 1.19, 1.20 Oct 18, 2022
@madeline-k madeline-k added the pr/do-not-merge This PR should not be merged at this time. label Oct 18, 2022
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 7210407
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@corymhall corymhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was tried and reverted previously #20000.

I think we are dependent on the reduce module size project.

@cgarvis
Copy link
Contributor Author

cgarvis commented Oct 18, 2022

Looking at the original PR in #19756 it seems like it might work with the old kubectl lambda layer. Was hoping to unblock some folks that want to update EKS and aren't using the lambda layer for anything.

Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need integ tests to verify.

@TheRealAmazonKendra
Copy link
Contributor

The work in this has been superseded by @madeline-k and @kaizencc's PRs. Closing this one.

@cgarvis cgarvis deleted the cgarvis-eks-c8s-version branch November 30, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p1 pr/do-not-merge This PR should not be merged at this time.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants