Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(certificatemanager): unable to set removal policy on DnsValidatedCertificate #22122

Merged
merged 2 commits into from
Oct 2, 2022
Merged

fix(certificatemanager): unable to set removal policy on DnsValidatedCertificate #22122

merged 2 commits into from
Oct 2, 2022

Commits on Sep 19, 2022

  1. fix(certificatemanager): unable to set removal policy on DnsValidated…

    …Certificate
    
    This PR adds a method override for applyRemovalPolicy which allows the user to specify a removal policy for the DnsValidatedCertificate construct. Since this construct is backed by a custom resource, the lambda handler was updated to no longer delete the certificate if the RemovalPolicy is set to retain.
    
    This is also needed to allow for an easier migration from DnsValidatedCertificate -> Certificate
    
    reroll of #22040
    This has the same changes as #22040 with the addition of some logic to
    handle only processing updates for certain parameters. If
    `RemovalPolicy` is changed for example, the update will not
    be processed.
    
    I also added an integration test with some manual instructions. In order
    to test ACM certificates I also updated the integ-runner to handle some
    additional special env variables.
    
    fixes #20649
    corymhall committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    a531990 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2022

  1. Configuration menu
    Copy the full SHA
    c9ae40b View commit details
    Browse the repository at this point in the history