Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apigateway): Add contextOwnerAccountId log pattern #21989

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

jmortlock
Copy link
Contributor

@jmortlock jmortlock commented Sep 10, 2022

Closes: #21731

As mentioned in the referenced PR the contextAccountId doc string contained the wrong docstring as it in fact returns the
callers account id.

Implemented a the fix as per the ticket recommendation.


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 10, 2022

@github-actions github-actions bot added the p2 label Sep 10, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team September 10, 2022 00:26
@jmortlock jmortlock changed the title feat(apigateway): Add contextOwnerAccountId log pattern fix(apigateway): Add contextOwnerAccountId log pattern Sep 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: c26c71f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit c24027b into aws:main Sep 14, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 14, 2022

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-apigateway: Custom log format account ID gets translated incorrectly
3 participants