fix(elbv2): connections not created for chained listener actions #21939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When you add an action to a listener the `bind` method is called, and
one of the things that is typically done is to configure security group
ingress. When you chain actions together, i.e.
```ts
listener.addAction('first-action', {
action: ListenerAction.authenticateOidc({
next: ListenerAction.forward([secondAction]),
...,
}),
});
```
Bind is never called for the second action (i.e. `next`) which means the
security group ingress rules are not created.
This PR updates the `ListenerAction.bind` method to call `bind` for any
`next` action that is configured.
fixes #12994
|
|
github-actions
bot
added
bug
corymhall
commented
Sep 7, 2022
| @@ -173,10 +173,7 @@ export class ListenerAction implements IListenerAction { | |||
| * Called when the action is being used in a listener | |||
| */ | |||
| public bind(scope: Construct, listener: IApplicationListener, associatingConstruct?: IConstruct) { | |||
| // Empty on purpose | |||
| Array.isArray(scope); | |||
There was a problem hiding this comment.
I honestly don't understand what this was doing.
|
@Mergifyio update |
✅ Branch has been successfully updated |
Naumel
approved these changes
Sep 8, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Kruspe
pushed a commit
to DavidSchwarz2/aws-cdk
that referenced
this pull request
Sep 13, 2022
…#21939) When you add an action to a listener the `bind` method is called, and one of the things that is typically done is to configure security group ingress. When you chain actions together, i.e. ```ts listener.addAction('first-action', { action: ListenerAction.authenticateOidc({ next: ListenerAction.forward([secondAction]), ..., }), }); ``` Bind is never called for the second action (i.e. `next`) which means the security group ingress rules are not created. This PR updates the `ListenerAction.bind` method to call `bind` for any `next` action that is configured. fixes aws#12994 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
May 5, 2023
…24510) ## Summary Allow HTTPS outbound traffic for security groups attached to the Application Load Balancer if the Application Load Balancer is configured with an authentication configuration. ## Why is this PR needed? Application Load Balancer authentication requires HTTPS outbound traffic. However, the security group attached to the ApplicationLoadBalancer does not allow traffic to the outside, so the code as described in the documentation will not work by itself. <img width="593" alt="image" src="https://user-images.githubusercontent.com/49480575/223705838-a047e14c-95f5-4c8e-9003-0bbdf6b9d281.png"> This issue is also documented. https://aws.amazon.com/premiumsupport/knowledge-center/elb-configure-authentication-alb/?nc1=h_ls ## Related issues Following opened issues were fixed by #21939, but related this PR. Closes #19035 #18944. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add an action to a listener the
bindmethod is called, and one of the things that is typically done is to configure security group ingress. When you chain actions together, i.e.Bind is never called for the second action (i.e.
next) which means the security group ingress rules are not created.This PR updates the
ListenerAction.bindmethod to callbindfor anynextaction that is configured.fixes #12994
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license