Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rds): add support for database instances #2187
feat(rds): add support for database instances #2187
Changes from 26 commits
ef9a9cf
1c17af4
e55b6fc
8c31724
cc49f71
d798e0c
6cc4e88
c890989
2e5b611
ee391c8
fe17f60
2aed438
9249aff
3b9bc6e
4150e19
8078dcf
b91e3a3
737bcaa
b817d92
6dd669d
a9b8792
34627f8
305db7b
ab5c6f3
96f14ee
7c5526a
e7b62b0
4578cca
b589ed4
ee8d067
c2a2c92
e06616f
c8b185e
25e406f
f8ac7cb
13fb8c7
e852acf
c392fbb
28b0d59
6f8eec8
d044e64
c904e99
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an actual event name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it's the
id
:Only the generic
onEvent
has been implemented (there are way too many events possible for RDS instances: snapshots, failover, reboot, restart, logs, security groups...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer noting "cluster or instance".
Also,
RDS database+s+ have
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean it's not so much that there's a default port as it is that the RDS instance has an intrinsic (known) port.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be that a non-standard
port
was set at instance creation (e.g. not 3306 for MySQL).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
database cluster
notcluster database
(at least that's how I think of it)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would rather specify when stuff applies only to
cluster
orinstance
, and assume it applies to either when not specified.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of linking this way (especially as it'll link to a possibly un-released version of the
README
, which might create confusion). I see why you'd want to do that however, and this might be a gap in our documentation story!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree
This file was deleted.
This file was deleted.