Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(aws-ecs): handle long ARN formats for services #2176

Merged
merged 5 commits into from
Apr 5, 2019
Merged

fix(aws-ecs): handle long ARN formats for services #2176

merged 5 commits into from
Apr 5, 2019

Commits on Apr 4, 2019

  1. fix(aws-ecs): handle long ARN formats for services 

    Due to a bug in Cloudformation, Fn::GetAtt for service name on an ECS
service was returning the cluster name instead of the service name. This
was causing the ResourceId on
AWS::ApplicationAutoScaling::ScalableTarget to be set incorrectly.

This change forces the customer to specify whether they have opted into
the long ARN format for services (which can be achieved through the following command:
`aws ecs put-account-setting-default --name serviceLongArnFormat --value
enabled`). The CDK cannot currently detect if the customer has the these
settings enabled so there could be a potential conflict on deployment.

Fixes aws#1849.
    @SoManyHs
    SoManyHs committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    bcdda38 View commit details
    Browse the repository at this point in the history

  2. Revert integ test change 

    Test account won't be able to verify long ARN settings
    @SoManyHs
    SoManyHs committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    4c04a30 View commit details
    Browse the repository at this point in the history

  3. Remove longArnEnabled as public property on service

    @SoManyHs
    SoManyHs committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    f9b4348 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into fix-autoscaling

    @SoManyHs
    SoManyHs committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    11fada2 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into fix-autoscaling

    @SoManyHs
    SoManyHs committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    0855b44 View commit details
    Browse the repository at this point in the history