Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary line in instructions. #2173

Merged
merged 1 commit into from
Apr 3, 2019
Merged

Conversation

garnaat
Copy link
Contributor

@garnaat garnaat commented Apr 3, 2019

The call to python setup.py develop is not needed and is confusing. Fixes #2171.

Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@garnaat garnaat added the language/python Related to Python bindings label Apr 3, 2019
@garnaat garnaat self-assigned this Apr 3, 2019
@garnaat garnaat requested a review from a team as a code owner April 3, 2019 14:07
@garnaat garnaat merged commit 732aa5b into aws:master Apr 3, 2019
@garnaat garnaat deleted the fix_2171 branch April 3, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/python Related to Python bindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary step in README.md for Python app template
2 participants