Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ec2): add P4DE instances (in developer preview) #21590

Merged
merged 3 commits into from
Aug 15, 2022
Merged

feat(ec2): add P4DE instances (in developer preview) #21590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebaa419
feat(ec2): add P4DE instances (in developer preview)
jumic Aug 13, 2022
2b9d932
fix wrong value
jumic Aug 15, 2022
d286c71
Merge branch 'main' into ec2-instance-type-p4de
mergify[bot] Aug 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions packages/@aws-cdk/aws-ec2/lib/instance-types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,6 +753,17 @@ export enum InstanceClass {
*/
P3DN = 'p3dn',


/**
* Parallel-processing optimized instances with local NVME drive, extended, 4th generation (in developer preview)
*/
PARALLEL4_NVME_DRIVE_EXTENDED = 'parallel4-nvme-drive-extended',

/**
* Parallel-processing optimized instances with local NVME drive, extended, 4th generation (in developer preview)
*/
P4DE = 'p4de',

/**
* Parallel-processing optimized instances, 4th generation
*/
Expand Down Expand Up @@ -1171,6 +1182,8 @@ export class InstanceType {
[InstanceClass.P3]: 'p3',
[InstanceClass.PARALLEL3_NVME_DRIVE_HIGH_PERFORMANCE]: 'p3dn',
[InstanceClass.P3DN]: 'p3dn',
[InstanceClass.PARALLEL4_NVME_DRIVE_EXTENDED]: 'p4de',
[InstanceClass.P4DE]: 'p4de',
[InstanceClass.PARALLEL4]: 'p4d',
[InstanceClass.P4D]: 'p4d',
[InstanceClass.ARM1]: 'a1',
Expand Down
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-ec2/test/instance.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ describe('instance', () => {
});
test('instance architecture is correctly discerned for x86-64 instance', () => {
// GIVEN
const sampleInstanceClasses = ['c5', 'm5ad', 'r5n', 'm6', 't3a', 'r6i', 'r6a']; // A sample of x86-64 instance classes
const sampleInstanceClasses = ['c5', 'm5ad', 'r5n', 'm6', 't3a', 'r6i', 'r6a', 'p4de']; // A sample of x86-64 instance classes

for (const instanceClass of sampleInstanceClasses) {
// WHEN
Expand Down