feat(appsync): set max batch size when using batch invoke #20995
Conversation
|
|
github-actions
bot
added
p2
effort/small
| @@ -112,6 +118,7 @@ export class Resolver extends Construct { | |||
| requestMappingTemplate: props.requestMappingTemplate ? props.requestMappingTemplate.renderTemplate() : undefined, | |||
| responseMappingTemplate: props.responseMappingTemplate ? props.responseMappingTemplate.renderTemplate() : undefined, | |||
| cachingConfig: this.createCachingConfig(props.cachingConfig), | |||
| maxBatchSize: props.maxBatchSize, | |||
There was a problem hiding this comment.
Should it not be undefined if it's not specified?
There was a problem hiding this comment.
Yes, will change it.
There was a problem hiding this comment.
If props.maxBatchSize isn't specified, it would be undefined with the code as is. maxBatchSize: props.maxBatchSize ? props.maxBatchSize : undefined; is redundant, unless there's something I'm missing.
There was a problem hiding this comment.
@TheRealAmazonKendra
You are probably right (I am not too familiar with typescript). I think there is no drawback if it is checked. Actually, it adds some consistency, since other variables are checked as well (line 115 probs.dataSourceName).
There was a problem hiding this comment.
It's checked in line 115 because it's setting dataSourceName to props.dataSource.name. In this case, it would throw an error if props.dataSource is undefined.
The whole line: dataSourceName: props.dataSource ? props.dataSource.name : undefined,
That check is just redundant here, like it would be in lines 112-114.
There was a problem hiding this comment.
I have missed that. I will just revert it, removing the redundant call.
|
@TheRealAmazonKendra, am I required to add this single field to the |
TheRealAmazonKendra
changed the title
TheRealAmazonKendra
added
the
pr-linter/exempt-readme
TheRealAmazonKendra
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
closes #20467
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license