Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Sagemaker) Allow Sagemaker Endpoint to be defined via L2 construct #20941

Closed
wants to merge 6 commits into from
Closed

feat(Sagemaker) Allow Sagemaker Endpoint to be defined via L2 construct #20941

wants to merge 6 commits into from

Conversation

unavailablealfaa
Copy link

Add SageMaker endpoint L2 construct to allow clients to define endpoint used to deploy and host models.

RPC: aws/aws-cdk-rfcs#441

All Submissions:

Adding new Unconventional Dependencies:

  • [ NA ] This PR adds new unconventional dependencies following the process described here

New Features

  • [ NA ] Have you added the new feature to an integration test?
    • [ NA ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

unavailablealfaa and others added 3 commits June 30, 2022 14:33
@unavailablealfaa
Add Sagemaker Endpoint L2 construct
85a5479 
Add SageMaker endpoint L2 construct to allow clients to define endpoint used to deploy and host models.

RPC No.: 441
Update aws-sagemaker model version to 0.0.0 following cdk convention
173a5b1 
Update aws-sagemaker model version to 0.0.0 following cdk convention
Remove unnecessary file
dff3046
@gitpod-io
Copy link

gitpod-io bot commented Jun 30, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team June 30, 2022 22:45
@github-actions github-actions bot added the p2 label Jun 30, 2022
@TheRealAmazonKendra
Copy link
Contributor

We require an approved RFC before we can review the PR for a new L2 Construct. Looks like you've opened a new issue for the RFC but not actually written the RFC or gotten approval. I'm marking this as a draft for now, but once the RFC has been approved and the relevant changes have been made to this PR, please mark it as ready for review.

@TheRealAmazonKendra TheRealAmazonKendra marked this pull request as draft July 14, 2022 05:00
@unavailablealfaa
Copy link
Author

Thanks for your response @TheRealAmazonKendra, I missed the readme part in RFC process, will submit it for review.

aws-cdk-automation
aws-cdk-automation requested changes Oct 31, 2022
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@aws-cdk-automation
Copy link
Collaborator

The pull request linter fails with the following errors:

❌ Features must contain a change to an integration test file and the resulting snapshot.
❌ The title of this pull request does not follow the Conventional Commits format, see https://www.conventionalcommits.org/.

PRs must pass status checks before we can provide a meaningful review.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 49d1a33
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

11 similar comments
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@kaizencc
Copy link
Contributor

Closing this for staleness. However, @unavailablealfaa this construct is being actively worked on in #22886 and should be ready soon.

@kaizencc kaizencc closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aws-cdk-automation aws-cdk-automation aws-cdk-automation requested changes

Assignees
No one assigned
Labels
p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@unavailablealfaa @TheRealAmazonKendra @aws-cdk-automation @kaizencc