Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cognito): OpenID Connect identity provider #20241
feat(cognito): OpenID Connect identity provider #20241
Changes from 4 commits
94314cf
7ffd9eb
6e83bf8
13c295b
f6186fd
36aec8c
7e96e6f
0b86bc1
a489c20
1a724f7
d2266e7
4bf430a
10771c1
5957e37
cba729c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to use
physicalName
here and generate one if the user doesn't provide one? It doesn't look like OIDC has a specific name requirement like the others.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean
the provider name is required in
AWS::Cognito::UserPoolIdentityProvider
(CF) andUserPoolIdentityProviderOidc
doesn't extendResource
directly so there is no physical name prop?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh I missed that it wasn't extending
Resource
directly. How about:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
id
might be a better default since the provider name is limited to 32 chars? (could add validation)