Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooling): container user's uid does not match host's uid #20082

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

sarisia
Copy link
Contributor

@sarisia sarisia commented Apr 26, 2022

Docker jsii/superchain image, which is used as a base image of devcontainer, has a
default non-root user superchain which UID is 1001.

If the container host's workspace directory is not owned by UID 1001, users may not be
able to modify files inside the container because of the insufficient permission.

.devcontainer.json has a workaround option updateRemoteUserUID
which updates container's non-root user's UID at runtime.

This PR sets remoteUser explicitly in .devcontainer.json to make updateRemoteUserUID work.

fixes #19979


All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 26, 2022

@github-actions github-actions bot added bug This issue is a bug. p2 labels Apr 26, 2022
@aws-cdk-automation aws-cdk-automation requested a review from a team April 26, 2022 01:26
@TheRealAmazonKendra TheRealAmazonKendra changed the title fix(tooling): ensure container user's uid matches host's uid fix(tooling): container user's uid does not match host's uid Apr 26, 2022
@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-test The PR linter will not require test changes label Apr 26, 2022
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! Looks like your fork isn't allowing mergify to push to it. Please enable that so it can updated and then we can merge the change. Here are instructions on how to do so, if needed.

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@sarisia
Copy link
Contributor Author

sarisia commented Apr 26, 2022

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

refresh

✅ Pull request refreshed

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: f47bc20
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e9670c8 into aws:master Apr 26, 2022
@mergify
Copy link
Contributor

mergify bot commented Apr 26, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. p2 pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(.devcontainer.json): Development container opens project with incorrect permissions
3 participants