fix(lambda-python): Pipenv projects no longer work for Python 3.6 #20019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pipenv` has dropped support for Python 3.6. Our install command was installing the latest `pipenv`, but that will start failing. Instead, pin to the latest version that still supports 3.6.
rix0rrr
added
pr-linter/exempt-test
|
|
corymhall
reviewed
Apr 21, 2022
| RUN pip install pipenv poetry | ||
|
|
||
| # pipenv 2022.4.8 is the last version with Python 3.6 support | ||
| RUN pip install pipenv==2022.4.8 poetry |
There was a problem hiding this comment.
We probably should handle this the same way we handle awscli with lambda-layer-awscli
aws-cdk/packages/@aws-cdk/lambda-layer-awscli/layer/Dockerfile
Lines 18 to 19 in 10f5ede
MrArnoldPalmer
approved these changes
Apr 21, 2022
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
rix0rrr
added a commit
that referenced
this pull request
Apr 21, 2022
…0019) `pipenv` has dropped support for Python 3.6. Our install command was installing the latest `pipenv`, but that will start failing. Instead, pin to the latest version that still supports 3.6. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr
added a commit
that referenced
this pull request
Apr 21, 2022
…0019) `pipenv` has dropped support for Python 3.6. Our install command was installing the latest `pipenv`, but that will start failing. Instead, pin to the latest version that still supports 3.6. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
…s#20019) `pipenv` has dropped support for Python 3.6. Our install command was installing the latest `pipenv`, but that will start failing. Instead, pin to the latest version that still supports 3.6. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pipenvhas dropped support for Python 3.6. Our install command wasinstalling the latest
pipenv, but that will start failing. Instead,pin to the latest version that still supports 3.6.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license