-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cloudwatch): support anomaly detection alarms #19956
Closed
brandondahler
wants to merge
2
commits into
aws:main
from
brandondahler:features/AnomalyDetectionAlarm
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -51,18 +51,24 @@ export enum ComparisonOperator { | |
/** | ||
* Specified statistic is lower than or greater than the anomaly model band. | ||
* Used only for alarms based on anomaly detection models | ||
* | ||
* @deprecated Use AnomalyDetectionAlarm instead. | ||
*/ | ||
LESS_THAN_LOWER_OR_GREATER_THAN_UPPER_THRESHOLD = 'LessThanLowerOrGreaterThanUpperThreshold', | ||
|
||
/** | ||
* Specified statistic is greater than the anomaly model band. | ||
* Used only for alarms based on anomaly detection models | ||
* | ||
* @deprecated Use AnomalyDetectionAlarm instead. | ||
*/ | ||
GREATER_THAN_UPPER_THRESHOLD = 'GreaterThanUpperThreshold', | ||
|
||
/** | ||
* Specified statistic is lower than the anomaly model band. | ||
* Used only for alarms based on anomaly detection models | ||
* | ||
* @deprecated Use AnomalyDetectionAlarm instead. | ||
*/ | ||
LESS_THAN_LOWER_THRESHOLD = 'LessThanLowerThreshold', | ||
} | ||
|
@@ -74,31 +80,6 @@ const OPERATOR_SYMBOLS: {[key: string]: string} = { | |
LessThanOrEqualToThreshold: '<=', | ||
}; | ||
|
||
/** | ||
* Specify how missing data points are treated during alarm evaluation | ||
*/ | ||
export enum TreatMissingData { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this move makes sense. This is directly related to creating an alarm. |
||
/** | ||
* Missing data points are treated as breaching the threshold | ||
*/ | ||
BREACHING = 'breaching', | ||
|
||
/** | ||
* Missing data points are treated as being within the threshold | ||
*/ | ||
NOT_BREACHING = 'notBreaching', | ||
|
||
/** | ||
* The current alarm state is maintained | ||
*/ | ||
IGNORE = 'ignore', | ||
|
||
/** | ||
* The alarm does not consider missing data points when evaluating whether to change state | ||
*/ | ||
MISSING = 'missing' | ||
} | ||
|
||
/** | ||
* An alarm on a CloudWatch metric | ||
*/ | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see a reason to do this. Can you explain why you want to deprecate these when they're used more widely than just in this context?