Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rds): MySQL Cluster version 8.0 uses wrong Parameter for S3 import #19145

Merged
merged 2 commits into from
Feb 25, 2022

Conversation

skinny85
Copy link
Contributor

There was recently a new major version of the Aurora MySQL released (8.0).
Apparently, it requires a different Parameter for S3 imports (aws_default_s3_role)
than aurora_load_from_s3_role, which the pre-8.0 versions use.

Fixes #19126


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

There was recently a new major version of the Aurora MySQL released (8.0).
Apparently, it requires a different Parameter for S3 imports (`aws_default_s3_role`)
than `aurora_load_from_s3_role`, which the pre-8.0 versions use.

Fixes aws#19126
@skinny85 skinny85 self-assigned this Feb 24, 2022
@gitpod-io
Copy link

gitpod-io bot commented Feb 24, 2022

@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Feb 24, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Feb 24, 2022
Copy link
Contributor

@comcalvi comcalvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cab5546
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 96b2034 into aws:master Feb 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@skinny85 skinny85 deleted the rds-mysql-8-param branch March 7, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws_rds): DatabaseCluster s3ImportRole fails with Aurora MySQL 3
3 participants