Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iotevents): add IoT Events input L2 Construct #17847
feat(iotevents): add IoT Events input L2 Construct #17847
Changes from 5 commits
3e069e9
4cda347
0f15502
a9ddebb
d1adc50
ed80896
fb25883
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
attributeJsonPaths
be empty? If not, can we validate that it's not? If it can be empty, can we make it optional, and default to[]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you said,
attributeJsonPaths
can not be empty. So I've been thinking that it is better to validate it too!On the other hand, I thought I had to make my initial L2 PR smaller so as not to repeat my previous mistakes😅 .
I never mind which ways, implement in this PR or after!😉I've fixed it!
This file was deleted.