feat(ecs-service-extensions): Enable default logging to CloudWatch for extensions (under feature flag) #17817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
upparekh
added
@aws-cdk-containers/ecs-service-extensions
iamhopaul123
reviewed
Dec 2, 2021
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Outdated
Show resolved
Hide resolved
paragbhingre
reviewed
Dec 3, 2021
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Show resolved
Hide resolved
upparekh
added
pr/work-in-progress
upparekh
changed the title
github-actions
bot
added
the
@aws-cdk/aws-cloudwatch
upparekh
changed the title
github-actions
bot
added
the
@aws-cdk/aws-cloudwatch
madeline-k
previously requested changes
Jan 6, 2022
There was a problem hiding this comment.
The user should be able to use this feature explicitly without adding the feature flag. The feature flag should just be there to prevent breaking changes when a user upgrades, and makes no code changes. The feature flag should not block the logGroup parameter entirely from being used. Hopefully that makes sense.
Said another way: Customers must take some action to opt-in to this behavior, it should not happen spontaneously when they upgrade. So, they can either turn on the feature flag, or set the logGroup property.
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-containers/ecs-service-extensions/lib/extensions/container.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk-containers/ecs-service-extensions/test/container.test.ts
Outdated
Show resolved
Hide resolved
madeline-k
changed the title
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
madeline-k
previously requested changes
Jan 12, 2022
packages/@aws-cdk-containers/ecs-service-extensions/test/service.test.ts
Show resolved
Hide resolved
mergify
bot
dismissed
madeline-k’s stale review
Pull request has been modified.
madeline-k
approved these changes
Jan 12, 2022
packages/@aws-cdk-containers/ecs-service-extensions/test/service.test.ts
Show resolved
Hide resolved
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…r extensions (under feature flag) (aws#17817) ---- This PR adds a default `awslogs` log driver to the application container. We first check if any other observability extensions (e.g. `FirelensExtension`) have already been added to the service. It will add the log driver only if no such loggers have been enabled. *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a default
awslogslog driver to the application container. We first check if any other observability extensions (e.g.FirelensExtension) have already been added to the service. It will add the log driver only if no such loggers have been enabled.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license