fix(aws-cdk): include nested stacks when building changesets #17396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for aws#5722 - users can do `cdk deploy --no-execute` and then view the nested changesets as a way to get a full diff of changes.
|
|
|
Title does not follow the guidelines of Conventional Commits. Please adjust title before merge. |
rectalogic
changed the title
rix0rrr
previously requested changes
Nov 9, 2021
rix0rrr
previously approved these changes
Nov 24, 2021
rix0rrr
approved these changes
Jan 4, 2022
rix0rrr
changed the title
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This is a workaround for aws#5722 - users can do `cdk deploy --no-execute` and then view the nested changesets as a way to get a full diff of changes. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
rix0rrr
pushed a commit
that referenced
this pull request
Mar 18, 2022
This is a workaround for #5722 - users can do `cdk deploy --no-execute` and then view the nested changesets as a way to get a full diff of changes. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Mar 29, 2022
This is a workaround for #5722 - users can do `cdk deploy --no-execute` and then view the nested changesets as a way to get a full diff of changes. This PR is a re-roll of #17396. That PR broke an integration test in the CLI, which this version fixes. Closes #19224. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
This is a workaround for aws#5722 - users can do `cdk deploy --no-execute` and then view the nested changesets as a way to get a full diff of changes. This PR is a re-roll of aws#17396. That PR broke an integration test in the CLI, which this version fixes. Closes aws#19224. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for #5722 - users can do
cdk deploy --no-executeand then view the nested changesets as a way to get a full diff of
changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license